-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add moq-gst-ietf #16
base: main
Are you sure you want to change the base?
Add moq-gst-ietf #16
Conversation
This landed in moq-rs at v0.2.0
Fix moq-native dep version
update moq-pub dependency
Add parameter to disable TLS verification
Add release-plz
feat: Use `gst-moq` programmatically
I think Luke plans to continue using moq-gst for transfork. Despite the fact that he hasn't published to crates.io under that name yet, I'd like to avoid confusion with the original repo.
Looks like we'll needs something like this, which is kind of gross to do for everything when it's really only necessary for moq-rs/moq-gst-ietf/.github/workflows/pr.yml Lines 22 to 24 in d57f08a
(Incidentally, there's a bit more cleanup I see I can do here of things pulled in by the subtree merge) |
Hmm, yeah.. Issues like this where our build can break because of build issues with dependencies of dependencies.. don't make me super excited about pulling this in to the main repo.
While this type of thing could theoretically happen with any of our deps, pulling in all of GStreamer as a requirement for I think it does make sense to keep a version of Thoughts, @levaitamas? |
hi @englishm ! |
Like #14, but includes the full history (via
git-subtree
) and then renames the crate to avoid confusion.If we run into issues with the big gstreamer dependency tree this brings in, I may move it back out into a separate repo again, but I'm OK trying this for now.