Fix ISE when creating fuel tanks

[enjinabner]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: Handling null values and zero values in fuel tank creation
• 📝 PR summary: This PR addresses an Internal Server Error (ISE) that was occurring when creating fuel tanks with null or zero values. The changes ensure that null values are handled correctly and that tests are updated to cover these scenarios.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 2, the changes are straightforward and mainly involve null checks and test updates.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The changes in this PR are well done. The null checks are properly implemented and the tests cover the new scenarios. However, it would be beneficial to add more context in the PR description to help reviewers understand the changes better.

• 🤖 Code feedback:

  • relevant file: src/GraphQL/Mutations/CreateFuelTankMutation.php
    suggestion: Consider using a default value for $accountRules in the method signature to avoid null checks. [medium]
    relevant line: '+ 'accountRules' => $accountRules?->toEncodable() ?? [],'

  • relevant file: src/Services/Blockchain/Implemetations/Substrate.php
    suggestion: The null check and assignment could be separated for better readability. [medium]
    relevant line: '+ (!is_null($maxFuelBurnPerTransaction = Arr::get($args, 'maxFuelBurnPerTransaction')))'

  • relevant file: tests/Feature/GraphQL/Mutations/CreateFuelTankTest.php
    suggestion: Consider adding assertions to check the specific values in the response, especially for the zero values test. [important]
    relevant line: '+ public function test_it_can_create_fuel_tank_with_zero_values(): void'

  • relevant file: tests/Feature/GraphQL/Traits/GenerateFuelTankData.php
    suggestion: The method generateData now accepts a second parameter $value. Consider adding a default value for it to maintain backward compatibility. [medium]
    relevant line: '+ protected function generateData($isArray = true, $value = null): array'

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38b671b) 97.18% compared to head (859729f) 97.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     97.18%   97.18%           
  Complexity      294      294           
=========================================
  Files            62       62           
  Lines          1776     1776           
=========================================
  Hits           1726     1726           
  Misses           50       50           

Files	Coverage Δ
src/GraphQL/Mutations/CreateFuelTankMutation.php	100.00% <100.00%> (ø)
...c/Services/Blockchain/Implemetations/Substrate.php	96.72% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.