Fix ISE when creating fuel tanks (#20)

[enjinabner]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: This PR addresses an internal server error (ISE) that was occurring when creating fuel tanks. It includes changes to handle null values and zero values in the code and adds a new test case to verify the fix.
• 📝 PR summary: The PR fixes an issue where an internal server error was thrown when creating fuel tanks. This was done by adding null checks and handling for zero values in the code. Additionally, a new test case was added to ensure that fuel tanks can be created with zero values.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 2, the PR is relatively small and straightforward. It includes changes to handle null and zero values and adds a new test case.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR seems to be well-structured and addresses the issue at hand effectively. The addition of a new test case to handle zero values is a good practice. However, it would be beneficial to add more context in the PR description to provide more information about the issue and how the changes fix it.

• 🤖 Code feedback:

  • relevant file: src/GraphQL/Mutations/CreateFuelTankMutation.php
    suggestion: Consider using a more descriptive default value instead of an empty array for 'accountRules'. This can improve code readability and understanding. [medium]
    relevant line: '+ 'accountRules' => $accountRules?->toEncodable() ?? [],'

  • relevant file: src/Services/Blockchain/Implemetations/Substrate.php
    suggestion: The null check for 'maxFuelBurnPerTransaction', 'userFuelBudget', and 'tankFuelBudget' can be made more readable by assigning the result of Arr::get() to a variable before the ternary operation. [medium]
    relevant line: '+ (!is_null($maxFuelBurnPerTransaction = Arr::get($args, 'maxFuelBurnPerTransaction)))'

  • relevant file: tests/Feature/GraphQL/Mutations/CreateFuelTankTest.php
    suggestion: Consider adding assertions to check the actual values in the response in the 'test_it_can_create_fuel_tank_with_zero_values' test. This will ensure that the function behaves as expected when it receives zero values. [important]
    relevant line: '+ public function test_it_can_create_fuel_tank_with_zero_values(): void'

  • relevant file: tests/Feature/GraphQL/Traits/GenerateFuelTankData.php
    suggestion: The 'generateData' function now accepts a second parameter 'value'. It would be helpful to add a comment explaining what this parameter is used for. [medium]
    relevant line: '+ protected function generateData($isArray = true, $value = null): array'

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38b671b) 97.18% compared to head (70b83c7) 97.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             release      #21   +/-   ##
==========================================
  Coverage      97.18%   97.18%           
  Complexity       294      294           
==========================================
  Files             62       62           
  Lines           1776     1776           
==========================================
  Hits            1726     1726           
  Misses            50       50           

Files	Coverage Δ
src/GraphQL/Mutations/CreateFuelTankMutation.php	100.00% <100.00%> (ø)
...c/Services/Blockchain/Implemetations/Substrate.php	96.72% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.