-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not build on Mac OS X Darwin #246
Comments
Looking at e.g. https://github.com/bazelbuild/examples/tree/main/cpp-tutorial/stage1 does not mention that a Toolchain has to be manually configured on Mac to build C++ with Bazel. So this seems to be specifically related either to one of the Bazel modules which this project uses. I would like to narrow down which one... is it specific (and only) affecting the https://rules-proto-grpc.com stuff, as the error above mentions, or does it also affect the existing "basic" Java & Go Proto generation? @teivah could you post the output when you run the following commands:
|
|
The above "proves" (I think) that this has nothing to do e.g. with https://rules-proto-grpc.com/ specifically, and that its stuck with the (basic)
Actually, just to be extra double sure, would you mind to try to run that on (your) Mac? |
All good
|
In that case, let's try out a totally trivial simple standalone project with JUST a Does https://github.com/vorburger/LearningBazel/tree/develop/proto_library work on (your) Mac? |
@teivah confirmed that it does. So it's something particular to this project. This seems like a good opportunity to do some clean-up, and tentatively remove |
#202 as a reminder what was what re. protos build; I will finish that clean up at this occasion. |
I'm finally able to run
|
Cool!! And you mentioned there are some Java test failures - let's keep this issue open to address those. |
Yes, sorry, here's the exact log:
|
@teivah do you have any interest to contribute (minor) fixes to make the test pass on Mac? PR with docs update to https://docs.enola.dev/dev/setup/ for OS X may also make sense... notably re. Xcode! (That's just so weird.. why?!) I guess you could even add a GitHub Action for Mac, to prevent future regression. BTW FYI the project now also has a Development Environment in a Docker Container... is that easier, on Mac? |
There were 2 unrelated test failures shown above:
|
ec29b29 had already fixed that, actually. @teivah do you have any interest to recheck to confirm that it now builds clean on Mac OS X Darwin? |
Expected Behavior
Running
test.bash
should return a successActual Behavior
Steps to Reproduce the Problem
test.bash
on a Mac OS machineSpecifications
The text was updated successfully, but these errors were encountered: