Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaTypeDetectorTest fails on some machines #509

Closed
vorburger opened this issue Feb 19, 2024 · 0 comments · Fixed by #609
Closed

MediaTypeDetectorTest fails on some machines #509

vorburger opened this issue Feb 19, 2024 · 0 comments · Fixed by #609
Assignees
@vorburger
Labels
bug Something isn't working build Build, CI, etc. (w.o. #testing) contributors Affects Contributors (not users) good first issue Good for newcomers google Google.com help wanted Extra attention is needed

Comments

@vorburger
Copy link
Member 

1) testDetect(dev.enola.common.io.mediatype.MediaTypeDetectorTest)
value of: detect(...)
expected: application/yaml; charset=utf-8
but was : application/yaml
	at dev.enola.common.io.mediatype.MediaTypeDetectorTest.testDetect(MediaTypeDetectorTest.java:60)

This is likely because code somewhere (inadvertently) uses platform specific encoding...
@vorburger vorburger added bug Something isn't working build Build, CI, etc. (w.o. #testing) google Google.com contributors Affects Contributors (not users) labels Feb 19, 2024
@vorburger vorburger self-assigned this Feb 19, 2024
@vorburger vorburger added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 21, 2024
vorburger added a commit to vorburger/enola that referenced this issue Mar 24, 2024
@vorburger
fix (core): Hard-code YAML to be UTF-8 instead defaultCharset() (fixes …
6474924 
…enola-dev#509)
This was referenced Mar 24, 2024
Merged
Open
vorburger added a commit that referenced this issue Mar 24, 2024
@vorburger
fix (core): Hard-code YAML to be UTF-8 instead defaultCharset() (fixes …
7c7995f 
…#509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vorburger vorburger

Labels
bug Something isn't working build Build, CI, etc. (w.o. #testing) contributors Affects Contributors (not users) good first issue Good for newcomers google Google.com help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hard-code YAML to be UTF-8 instead defaultCharset() vorburger/enola
1 participant
@vorburger