Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

300% benchmarks regression between Dec 13 and 14 #11901

Closed
1 of 2 tasks
JaroslavTulach opened this issue Dec 18, 2024 · 2 comments · Fixed by #11913
Closed
1 of 2 tasks

300% benchmarks regression between Dec 13 and 14 #11901

JaroslavTulach opened this issue Dec 18, 2024 · 2 comments · Fixed by #11913
Assignees
Labels
-compiler p-highest Should be completed ASAP

Comments

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Dec 18, 2024

There is a huge regression in many engine benchmarks and some stdlib ones between Dec 13 and Dec 14:

performance drop

@JaroslavTulach
Copy link
Member Author

The regression has happened between following commits e9b0ba9 and e9b0ba9 which leaves us with only one suspect:

git log e9b0ba95b087210ceb4b988473d6ec219ebb939c...63ed62921012f57b7a5cf169351e8872c2fde59a
commit 63ed62921012f57b7a5cf169351e8872c2fde59a (tag: 2024.5.1-nightly.2024.12.16, tag: 2024.5.1-nightly.2024.12.15, tag: 2024.5.1-nightly.2024.12.14)
Author: James Dunkerley <jdunkerley@users.noreply.github.com>
Date:   Fri Dec 13 21:01:16 2024 +0000

    Excel Reading (XLSX) using SAX Default Handler (#10877)
    
    - Implement Excel reading as a SAXMLParser.

commit e6bcd5e485a82abe9b0fd5364c8a1b98c926171f
Author: Radosław Waśko <radoslaw.wasko@enso.org>
Date:   Fri Dec 13 20:28:03 2024 +0100

    `aggregate ..Sum` of integer column remains integer and handles overflow (#11860)
    
    - This was mentioned in #7192 but didn't get a proper ticket.
    - Ensuring that summing integers gives an integer and not a float.
    - Only in-memory, as in Database the result type is database-dependent and we want it to be like that.
    - Also allowing the integer sum to overflow and become a `BigInteger`, in that case the resulting column will become `Decimal`.

commit be6eb1e49f8256fd0bab49094b6c1f3b84764c52
Author: Paweł Buchowski <pawel.buchowski@enso.org>
Date:   Fri Dec 13 20:14:21 2024 +0100

    Fix sending same refreshToken as accessToken in open project request (#11862)
    
    In `open_project` request body we send `cognitoCredentials` for the project to be able to communicate with Cloud API. Currently the `refreshToken` has the same value as `accessToken` making that communication buggy.

commit 7998ed52181258996f530ecc7b8301532ca1b986
Author: Jaroslav Tulach <jaroslav.tulach@enso.org>
Date:   Fri Dec 13 16:02:51 2024 +0100

    case of and intersection types (#11850)
    
    Also: Prefer `getURI` path when gathering location of a source

@JaroslavTulach JaroslavTulach self-assigned this Dec 18, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Dec 18, 2024
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to ⚙️ Design in Issues Board Dec 19, 2024
@JaroslavTulach JaroslavTulach moved this from ⚙️ Design to 👁️ Code review in Issues Board Dec 19, 2024
@mergify mergify bot closed this as completed in #11913 Dec 19, 2024
@mergify mergify bot closed this as completed in 071a14a Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 19, 2024
@enso-bot
Copy link

enso-bot bot commented Dec 19, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-12-19):

Progress: .

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler p-highest Should be completed ASAP
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

1 participant