Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure isAllTypes is compilation constant #11913

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Dec 19, 2024

Pull Request Description

Fixes #11901 up by making sure isAllTypes() is a compilation constant.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 19, 2024
@JaroslavTulach JaroslavTulach self-assigned this Dec 19, 2024
@JaroslavTulach
Copy link
Member Author

Benchmarks seem to be back on its previous speed:
bench is good
Looks like 086d024 is the right fix.

@JaroslavTulach JaroslavTulach added CI: Ready to merge This PR is eligible for automatic merge CI: Keep up to date Automatically update this PR to the latest develop. labels Dec 19, 2024
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit of a mystery to me why prefer compilationConstant instead of partialEvaluationConstant as per javadoc but I trust you more with this black magic.

@mergify mergify bot merged commit 071a14a into develop Dec 19, 2024
46 of 48 checks passed
@mergify mergify bot deleted the wip/jtulach/SpeedCaseOfUp11901 branch December 19, 2024 18:25
@JaroslavTulach
Copy link
Member Author

It's a bit of a mystery to me why prefer compilationConstant instead of partialEvaluationConstant as per javadoc but I trust you more with this black magic.

True, let's fix it at 775595c and merge with some other PR.

The important fix is the @ExplodeLoop annotation that allows the for(;;) to be unrolled into individual statements and makes it possible for the vn to be a constant. There rest are just asserts to verify the assumption holds which need not be present at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

300% benchmarks regression between Dec 13 and 14
2 participants