-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run black on the codebase #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have preferred it if the changes in this PR were actually in two separate PRs - one for the package and another for the examples.
@@ -725,5 +766,5 @@ def create_plot_types(names): | |||
save_plot(window.container, fname) | |||
|
|||
|
|||
if __name__ == '__main__': | |||
if __name__ == "__main__": | |||
main() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronayres35 looks like there already is a script to generate the chaco demo plots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this script generates a plot for each plot type, not necessarily all the examples/demos (ie. not everything we show on the "gallerry"/"annotated examples" page). However, yes this is super useful and could likely be modified to regenerate all the demo plots
lplot.overlays.append(LineInspector(component=lplot, | ||
axis="value", write_metadata=True, is_listener=True, color="blue")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there was a copy-paste error here. and below too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be handled in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @aaronayres35 let's have a chat monday morning before you merge this PR.
|
||
config.add_extension('contour',['*.c'],**numerix_info) | ||
config.add_data_dir('tests') | ||
numerix_info = config.get_info("numerix") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have no clue what numerix_info
is but i suspect it's dead code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't looks like it is but im not what it does.
"bounds", | ||
"bounds_items", | ||
"label_at_top", | ||
): | ||
self._layout_needed = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's another fun little trait which seems to have a trait change handler hooked up somewhere which redraws or something when it is set.
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
A first step towards having a flake8 clean codebase
commands run: