Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run flake8 on CI but ignore all existing errors #600

Merged
merged 10 commits into from
Apr 5, 2021
Merged

Conversation

aaronayres35
Copy link
Contributor

NOTE: this PR sits on top of #599

I figured having run black on the code base before setting up flake8 machinery made sense

This PR sets up flake8 to run on CI so that new flake8 errors aren't introduced. It ignores all the currently existing flake8 errors (there are a lot, filenames were found via flake8 -q and added to the tox.ini exclude list)

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from black-codebase to master April 5, 2021 15:04
@aaronayres35 aaronayres35 merged commit c758a65 into master Apr 5, 2021
@rahulporuri rahulporuri deleted the flake8-on-CI branch April 7, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants