Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to chaco.shell from the documentation #669

Merged
merged 6 commits into from
Apr 19, 2021

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Apr 15, 2021

Along with #668, this PR closes #463

This PR removes any lingering mention of chaco.shell from the documentation. In doing so it removes the entire tutorial with ipython, and other smaller portions of the docs describing use of chaco.shell

Comment on lines 104 to 105
Script-oriented plotting
========================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is stil worth comparing/contrasting these two styles - script-oriented vs application-oriented - so we would be using matplotlib instead of chaco.shell to demonstrate the script-oriented style of plotting.

docs/source/user_manual/chaco_tutorial.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 4e7831c into master Apr 19, 2021
@aaronayres35 aaronayres35 deleted the doc/remove-shell branch April 19, 2021 14:35
rahulporuri pushed a commit that referenced this pull request Apr 22, 2021
the doc page which used these images was removed in the PR #669
but we forgot to remove the images in the PR

	deleted:    docs/source/user_manual/images/ipython_basic.png
	deleted:    docs/source/user_manual/images/ipython_kde.png
	deleted:    docs/source/user_manual/images/ipython_multi.png
rahulporuri pushed a commit that referenced this pull request Apr 22, 2021
* CLN : Remove chaco.shell related images from docs

the doc page which used these images was removed in the PR #669
but we forgot to remove the images in the PR

	deleted:    docs/source/user_manual/images/ipython_basic.png
	deleted:    docs/source/user_manual/images/ipython_kde.png
	deleted:    docs/source/user_manual/images/ipython_multi.png

* CLN : Remove images from quickstart page which got removed

the quickstart page got removed in #668

	deleted:    docs/source/images/lines.png
	deleted:    docs/source/images/lines_final.png
	deleted:    docs/source/images/mylineplot.png
	deleted:    docs/source/images/simple_line.png
	deleted:    docs/source/user_manual/images/simple_line.png

* CLN : Remove another copy of simple_line

and just use the one image everywhere needed in docs

	modified:   docs/source/user_manual/annotated_examples.rst
	deleted:    docs/source/user_manual/example_images/simple_line.png

* CLN : I am not even sure what the xcf file is

but it isnt used in the docs so lets remove it

	deleted:    docs/source/images/chaco_show.xcf

* FIX : Dont delete all copies of simple_line

and use the one copy everywhere

	new file:   docs/source/images/simple_line.png
	modified:   docs/source/user_manual/annotated_examples.rst
	modified:   docs/source/user_manual/chaco_tutorial.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove chaco.shell
2 participants