Delete the quickstart page from the docs #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
reviewed
Apr 16, 2021
Comment on lines
-106
to
-107
| First plots from IPython | ||
| ------------------------ |
There was a problem hiding this comment.
i'm not so sure about this PR. Why not just remove this "First plots from IPython" section instead? It's the only shell specific content that I see in this page.
There was a problem hiding this comment.
I thought we had discussed this while we went through the docs. The other sections were all redundant from the tutorial / I had "kill quickstart" written in my notes from our discussion.
I had this removal in a separate PR specifically because it wasn't only motivated by the removal of chaco.shell
There was a problem hiding this comment.
sorry. you're right. i was mistaking this page for something else. approving.
rahulporuri
approved these changes
Apr 16, 2021
|
@aaronayres35 can you hold off on this until we have a chat in 30 mins? Im sorry for flip-flopping |
rahulporuri
pushed a commit
that referenced
this pull request
Apr 22, 2021
the quickstart page got removed in #668 deleted: docs/source/images/lines.png deleted: docs/source/images/lines_final.png deleted: docs/source/images/mylineplot.png deleted: docs/source/images/simple_line.png deleted: docs/source/user_manual/images/simple_line.png
rahulporuri
pushed a commit
that referenced
this pull request
Apr 22, 2021
* CLN : Remove chaco.shell related images from docs the doc page which used these images was removed in the PR #669 but we forgot to remove the images in the PR deleted: docs/source/user_manual/images/ipython_basic.png deleted: docs/source/user_manual/images/ipython_kde.png deleted: docs/source/user_manual/images/ipython_multi.png * CLN : Remove images from quickstart page which got removed the quickstart page got removed in #668 deleted: docs/source/images/lines.png deleted: docs/source/images/lines_final.png deleted: docs/source/images/mylineplot.png deleted: docs/source/images/simple_line.png deleted: docs/source/user_manual/images/simple_line.png * CLN : Remove another copy of simple_line and just use the one image everywhere needed in docs modified: docs/source/user_manual/annotated_examples.rst deleted: docs/source/user_manual/example_images/simple_line.png * CLN : I am not even sure what the xcf file is but it isnt used in the docs so lets remove it deleted: docs/source/images/chaco_show.xcf * FIX : Dont delete all copies of simple_line and use the one copy everywhere new file: docs/source/images/simple_line.png modified: docs/source/user_manual/annotated_examples.rst modified: docs/source/user_manual/chaco_tutorial.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat of a follow up to #667
Without chaco.shell, the remaining content on this page is redundant and not needed. So, in this PR the page is removed entirely.