Revive ScalyPlot #744
Merged
Revive ScalyPlot #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#738 isn't relevant. Thank you! |
rahulporuri
approved these changes
May 31, 2021
| ) | ||
|
|
||
| def _index_scale_changed(self, old, new): | ||
| Plot._index_scale_changed(self, old, new) |
There was a problem hiding this comment.
Not entirely sure how this works. Shouldn't this be super()._index_scale_changed(old, new)? Same comment below with Plot._value_scale_changed(...)
There was a problem hiding this comment.
I agree, super makes more sense / is cleaner here. This code I believe is also untested, I simply copy pasted the old file to revive it.
It could probably use a closer look / some updates / some new tests. I can do so in some follow up PRs
|
Nice catch. How'd you notice it? |
There was a slack discussion which Robert tagged me in asking to revive it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalyPlotwas removed in #667, however it is still used / needed.It was independent of any other aspect of
chaco.shelland is brought back here to simply sit inchaco.scaly_plot.py.NOTE: we are planning some internal reorg (see #738), so this module may be moved in the future.It should be imported for the api module (I will add it to the api in this PR)