Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add points_in_polygon to kiva.agg with DeprecationWarning #279

Merged
merged 2 commits into from
Jun 29, 2017

Conversation

jwiggins
Copy link
Member

@rkern: As requested.

I'm depending a bit on CI here to test this since I was having 2to3 problems locally (in other modules).

@jwiggins
Copy link
Member Author

enthought/traitsui#369 should fix the broken CI run seen here...

@jwiggins
Copy link
Member Author

All the yaks have been shaved. I added a unit test.

@jwiggins
Copy link
Member Author

I moved the code to kiva/agg/__init__.py and fixed the unit test. Should be all good now. 🤞

@codecov-io
Copy link

codecov-io commented Jun 29, 2017

Codecov Report

Merging #279 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #279     +/-   ##
=========================================
+ Coverage   35.21%   35.42%   +0.2%     
=========================================
  Files         206      206             
  Lines       18215    18814    +599     
  Branches     2400     2627    +227     
=========================================
+ Hits         6414     6664    +250     
- Misses      11381    11724    +343     
- Partials      420      426      +6
Impacted Files Coverage Δ
kiva/agg/__init__.py 88.23% <100%> (+3.61%) ⬆️
enable/constraints_container.py 55.74% <0%> (-25.63%) ⬇️
enable/layout/layout_helpers.py 50.68% <0%> (-20.6%) ⬇️
enable/layout/linear_symbolic.py 87.5% <0%> (-12.5%) ⬇️
enable/primitives/shape.py 29.52% <0%> (-1.94%) ⬇️
kiva/agg/setup.py 0% <0%> (ø) ⬆️
enable/wx/cairo.py 0% <0%> (ø) ⬆️
enable/scrollbar.py 0% <0%> (ø) ⬆️
kiva/fonttools/font_manager.py 53.95% <0%> (+0.3%) ⬆️
kiva/abstract_graphics_context.py 98.29% <0%> (+0.49%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c2499...b4a18d3. Read the comment docs.

@rkern
Copy link
Member

rkern commented Jun 29, 2017

LGTM! Thanks!

@rkern rkern merged commit 819d15f into master Jun 29, 2017
@rkern rkern deleted the fix/p-i-p-deprecation branch June 29, 2017 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants