Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use import * to borrow imports from other modules #280

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Jun 27, 2017

Wow... so this unit test was depending on an import nose in a module which it was doing an import * from.

This fixes some test failures seen in #279

@rkern
Copy link
Member

rkern commented Jun 27, 2017

LGTM pending relevant Travis checks.

@jwiggins
Copy link
Member Author

Thanks. Note that I still expect failures because enthought/traitsui#369 has not yet been merged.

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #280 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   35.39%   35.39%           
=======================================
  Files         206      206           
  Lines       18806    18806           
  Branches     2627     2627           
=======================================
  Hits         6656     6656           
  Misses      11724    11724           
  Partials      426      426

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc6c10...ef16a20. Read the comment docs.

@jwiggins
Copy link
Member Author

OK. Only one failure (which was expected) from the CI run. I'm merging. Thanks for reviewing!

@jwiggins jwiggins merged commit 05c2499 into master Jun 27, 2017
@jwiggins jwiggins deleted the fix/unit-tests-breakage branch June 27, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants