Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand drag tool comments #452

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Expand drag tool comments #452

merged 1 commit into from
Nov 30, 2020

Conversation

notmatthancock
Copy link
Contributor

  • Adds additional explanatory comments to DragTool flags
  • Changes default value of end_drag_on_leave to False because the default value of True doesn't produce the described behavior

Closes #451

jwiggins
jwiggins approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notmatthancock notmatthancock merged commit e29a081 into master Nov 30, 2020
@notmatthancock notmatthancock deleted the doc/drag-tool branch November 30, 2020 15:15
@jwiggins jwiggins mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiggins jwiggins jwiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interplay between DragTool flags not clear
2 participants
@notmatthancock @jwiggins