Don't do unnecessary condition evaluations in assertEventuallyTrueInGui #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing for unrelated reasons. I suggest that we pin our PySide6 version in CI in the short term. |
|
#1169 should fix the unrelated CI failures, so that we can see whether there are any related failures. |
|
Looks like this makes some existing macOS tests unhappy. Investigating. |
…ns-in-gui-test-assistant' into fix/spurious-condition-evaluations-in-gui-test-assistant
|
Marking as draft, since there seem to be some unexpected interactions with the |
…ext manager" This reverts commit 76e9cc6.
mdickinson
commented
Nov 8, 2022
|
The failures for the font and color dialogs seem to be happening in the tests for the utility functions Possibly there is an issue with needed objects being gc'd or not cleaned up correctly? |
|
This should resolve #1170 as well. |
|
Thanks, @corranwebster. I'm happy for this to be merged if you are. |
corranwebster
deleted the
fix/spurious-condition-evaluations-in-gui-test-assistant
branch
corranwebster
added
the
needs backport to maint/*
corranwebster
added a commit
that referenced
this pull request
Nov 11, 2022
…ui (#1168) `GuiTestAssistant.assertEventuallyTrueInGui` does an unnecessary extra `condition` evaluation after the event loop has exited. In the worst case, when the condition is only valid during a running event loop, this can cause spurious test failures. This PR updates the code so that it doesn't re-evaluate the condition once the condition has evaluated to `True` for the first time. Design note: the `bool()` call is in there to avoid hanging onto references in case the user-supplied condition returns something more complicated that a simple bool. --- EDIT: I've also updated the PR to use the `exit` method instead of the `quit` method within `event_loop_until_condition`; all we want here is to exit the event loop that was started using `self.qt_app.exec_` - not to tear down anything else. Co-authored-by: Corran Webster <cwebster@enthought.com>
corranwebster
added a commit
that referenced
this pull request
Nov 14, 2022
…ui (#1168) `GuiTestAssistant.assertEventuallyTrueInGui` does an unnecessary extra `condition` evaluation after the event loop has exited. In the worst case, when the condition is only valid during a running event loop, this can cause spurious test failures. This PR updates the code so that it doesn't re-evaluate the condition once the condition has evaluated to `True` for the first time. Design note: the `bool()` call is in there to avoid hanging onto references in case the user-supplied condition returns something more complicated that a simple bool. --- EDIT: I've also updated the PR to use the `exit` method instead of the `quit` method within `event_loop_until_condition`; all we want here is to exit the event loop that was started using `self.qt_app.exec_` - not to tear down anything else. Co-authored-by: Corran Webster <cwebster@enthought.com>
corranwebster
restored the
fix/spurious-condition-evaluations-in-gui-test-assistant
branch
corranwebster
deleted the
fix/spurious-condition-evaluations-in-gui-test-assistant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuiTestAssistant.assertEventuallyTrueInGuidoes an unnecessary extraconditionevaluation after the event loop has exited. In the worst case, when the condition is only valid during a running event loop, this can cause spurious test failures.This PR updates the code so that it doesn't re-evaluate the condition once the condition has evaluated to
Truefor the first time.Design note: the
bool()call is in there to avoid hanging onto references in case the user-supplied condition returns something more complicated that a simple bool.EDIT: I've also updated the PR to use the
exitmethod instead of thequitmethod withinevent_loop_until_condition; all we want here is to exit the event loop that was started usingself.qt_app.exec_- not to tear down anything else.