Flake8 etstool.py #669
Flake8 etstool.py #669
Conversation
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 39.20% 39.27% +0.06%
==========================================
Files 491 491
Lines 26910 26911 +1
Branches 4065 4067 +2
==========================================
+ Hits 10551 10568 +17
+ Misses 15899 15889 -10
+ Partials 460 454 -6
Continue to review full report at Codecov.
|
| ) | ||
| elif sys.platform == "linux": | ||
| # XXX this is mainly for TravisCI workers; need a generic solution | ||
| commands.append( | ||
| "{edm} run -e {environment} -- pip install -f https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-14.04/ wxPython<4.1" | ||
| "{edm} run -e {environment} -- pip install -f https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-14.04/ wxPython<4.1" # noqa: E501 |
There was a problem hiding this comment.
this is tangential but we're not using the ubuntu 14.04 images on travis (i think xenial is 16.04) at the moment so i don't know if we should be using this url to download the expython wheels.
There was a problem hiding this comment.
yep xenial is 16.04 - https://docs.travis-ci.com/user/reference/linux#overview
There was a problem hiding this comment.
Yep, probably needs a different image. Not in this PR though.
There was a trailing whitespace that my IDE keeps trying to fix it for me whenever I save the file.
This PR lints the entire file for flake8 compliance.
I added
noqato silence flake8 in cases where it is better/readable to keep the integrity of a command than trying to break it up.