Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing ListItemAttr with ItemAttr to avoid deprecation warning #670

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

aaronayres35
Copy link
Contributor

See comments on #667.

We do not currently see the deprecation warning when using a wx environment created by the etstool in pyface as the development environment has pinned an older version of wxPython.
However, when using an environment with newer wx, there was the following deprecation warning (found when running the explorer.py example):

/Users/aayres/Desktop/pyface/pyface/ui/wx/viewer/table_viewer.py:313: wxPyDeprecationWarning: Using deprecated class. Use ItemAttr instead
  self._even_row_attribute = wx.ListItemAttr()
/Users/aayres/Desktop/pyface/pyface/ui/wx/viewer/table_viewer.py:318: wxPyDeprecationWarning: Using deprecated class. Use ItemAttr instead
  self._odd_row_attribute = wx.ListItemAttr()

@aaronayres35
Copy link
Contributor Author

CI is failing, I'm not sure why. I will try to look into this later today

@kitchoi
Copy link
Contributor

kitchoi commented Aug 14, 2020

Thank you @aaronayres35!

@corranwebster
Copy link
Contributor

Wx failure appears unrelated, but we've been getting a lot of linux/wx failures on multiple PRs. I've set the test to re-run, but if this continues, we may need to dig in a bit (or mark linux/wx test suites as being allowed to fail for CI to pass).

@kitchoi
Copy link
Contributor

kitchoi commented Aug 17, 2020

@rahulporuri spotted a version mismatch between Ubuntu version on Travis and the one targeted by the wxPython wheel used for CI. It might be related (or it might not be...)
#669 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #670 into master will increase coverage by 0.21%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   39.16%   39.37%   +0.21%     
==========================================
  Files         491      491              
  Lines       26911    26958      +47     
  Branches     4067     4085      +18     
==========================================
+ Hits        10539    10615      +76     
+ Misses      15906    15890      -16     
+ Partials      466      453      -13     
Impacted Files Coverage Δ
pyface/ui/wx/viewer/table_viewer.py 0.00% <0.00%> (ø)
pyface/util/testing.py 88.57% <ø> (ø)
pyface/__init__.py 88.88% <90.00%> (ø)
pyface/ui/qt4/console/console_widget.py 29.28% <0.00%> (+0.41%) ⬆️
pyface/ui/qt4/code_editor/code_widget.py 44.16% <0.00%> (+0.42%) ⬆️
pyface/ui/qt4/tasks/split_editor_area_pane.py 65.41% <0.00%> (+0.59%) ⬆️
pyface/ui/qt4/tasks/advanced_editor_area_pane.py 51.72% <0.00%> (+0.86%) ⬆️
pyface/ui/qt4/tasks/editor_area_pane.py 55.88% <0.00%> (+2.20%) ⬆️
pyface/ui/qt4/application_window.py 91.66% <0.00%> (+2.38%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c54cc...40676c5. Read the comment docs.

Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronayres35 aaronayres35 merged commit 562f9d2 into master Aug 18, 2020
@aaronayres35 aaronayres35 deleted the fix-deprecation-table_viewer branch August 18, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants