Remove a deprecated method from importlib_metadata
#991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dict interface from "importlib_metadata" is deprecated, so it must not be used as well.
|
I just have one question: where can I change the minimal required version of |
This comment has been minimized.
This comment has been minimized.
That way, the deprecated feature removed won't be harmful.
rahulporuri
reviewed
Jul 15, 2021
Convert a positional argument from "importlib_metadata.entry_points().select()" into a keyword argument. Co-authored-by: Poruri Sai Rahul <rahul.poruri@gmail.com>
Convert a positional argument from "importlib_metadata.entry_points().select()" into a keyword argument. Co-authored-by: Poruri Sai Rahul <rahul.poruri@gmail.com>
|
Thanks @rahulporuri for your help. Now let's see if it worked. |
rahulporuri
reviewed
Jul 16, 2021
the select interface was introduced in 3.6.0. ref https://importlib-metadata.readthedocs.io/en/latest/history.html#v3-6-0
rahulporuri
reviewed
Jul 16, 2021
this is because the select interface isn't available in any of the prior python versions
|
Thanks for the contribution @DiddiLeija ! |
|
Thanks @rahulporuri for merging and reviewing! |
mdickinson
reviewed
Jul 18, 2021
| @@ -187,7 +187,7 @@ def import_toolkit(toolkit_name, entry_point="pyface.toolkits"): | |||
| If no toolkit is found, or if the toolkit cannot be loaded for some | |||
| reason. | |||
| """ | |||
| entry_point_group = importlib_metadata.entry_points()[entry_point] | |||
| entry_point_group = importlib_metadata.entry_points().select(group=entry_point) | |||
There was a problem hiding this comment.
Unfortunately, this code fails on newer Python versions, where import importlib.metadata as importlib_metadata is used: the return value from entry_points() is then a plain dict, which doesn't have a select method.
There was a problem hiding this comment.
I've opened #998 to track this. It might also be good to see if we can get the CI tests running on Python 3.9, so that this sort of failure is detected earlier.
This was referenced Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #952. It removes a deprecated feature from importlib_metadata. See the reference here: https://importlib-metadata.readthedocs.io/en/latest/history.html#v3-9-0.