Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the select interface when using entry points #994

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

rahulporuri
Copy link
Contributor

This was missed in #991 and is needed to fully resolve #952 . The change introduced in this PR removes the deprecation warning raised by importlib_metadata from the test run as well.

2021-07-16T05:11:29.3287021Z test_core_plugins (pyface.tests.test_toolkit.TestToolkit) ... /home/runner/work/pyface/pyface/.edm/envs/pyface-test-3.6-pyqt5/lib/python3.6/site-packages/pyface/tests/test_toolkit.py:36: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
2021-07-16T05:11:29.3290051Z   plugins = {ep.name for ep in entry_points()['pyface.toolkits']}
2021-07-16T05:11:29.3290882Z ok

Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri removed the request for review from aaronayres35 July 16, 2021 09:42
@rahulporuri
Copy link
Contributor Author

thanks for the review @corranwebster

@rahulporuri rahulporuri merged commit 91c93ae into master Jul 16, 2021
@rahulporuri rahulporuri deleted the rahulporuri-patch-1 branch July 16, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning from "importlib_metadata"
2 participants