Test CLI command to retrieve quote and change endpoint / TSS account in one command #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameba23
commented
Dec 9, 2024
| Ok(<sr25519::Pair as Pair>::from_string(&mnemonic, None)?) | ||
| } | ||
|
|
||
| /// This is the same as [QuoteContext] but implements [ValueEnum] |
There was a problem hiding this comment.
Its annoying to have to do this but implementing clap::ValueEnum for QuoteContext would mean having clap as a dependency of entropy-shared.
* master: Bump thiserror from 2.0.4 to 2.0.6 in the patch-dependencies group (#1206) Downgrade parity-scale-codec as version we currently use has been yanked (#1205) Bump clap from 4.5.22 to 4.5.23 in the patch-dependencies group (#1202) Add oracle data pointer check (#1194) Bump tokio from 1.41.1 to 1.42.0 (#1196) Allow offchain worker requests to all TSS nodes in `entropy-tss` test environment (#1147) Bump the patch-dependencies group with 3 updates (#1195)
JesseAbram
approved these changes
Dec 9, 2024
ameba23
added a commit
that referenced
this pull request
Dec 13, 2024
* master: Add TDX test network chainspec (#1204) Test CLI command to retrieve quote and change endpoint / TSS account in one command (#1198) Bump the patch-dependencies group with 2 updates (#1212) Bump thiserror from 2.0.4 to 2.0.6 in the patch-dependencies group (#1206) Downgrade parity-scale-codec as version we currently use has been yanked (#1205) Bump clap from 4.5.22 to 4.5.23 in the patch-dependencies group (#1202)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the
change_endpointextrinsic to test attestation (by changing the endpoint to the same as what it was before, just to check the quote can be validated).The test-cli has a command to retrieve a quote and write it to a file, and and another command to change the endpoint with a quote given as a string. Its currently a bit tricky to convert the quote file to a string as its binary not utf8. Since these two things generally need to be done one after the other, this PR makes a single command which gets the quote and uses it in the
change_endpointorchange_threshold_accountsextrinsic.This PR also has some stuff tacked on which should really be in separate PRs:
change_endpoint/change_threshold_accountsclient functions.get-tdx-quotecommand to make it also take the context in which the quote will be used.