Step 1, build 3.7.2 bazel toolchains #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow this with adopting bazel 3.7.1 for envoy, wait hours for all builds in flight Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
|
This PR is staged as a draft, awaiting the announcement of bazel 3.7.1 perhaps Tuesday. |
This was referenced Nov 21, 2020
lizan
reviewed
Nov 22, 2020
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
…lvm11 Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
|
/retest |
|
Blocked on bazelbuild/bazel#12545 as well |
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
wrowe
changed the title
This fix is picked up in Bazel 3.7.2rc1 which we expect be released, this week. Updating migration patches now for this switch, and testing locally against 3.7.2 candidate. |
|
/retest |
|
@wrowe I don't think the |
sunjayBhatia
approved these changes
Dec 17, 2020
Merged
htuch
pushed a commit
that referenced
this pull request
Dec 17, 2020
[skip ci] build 3.7.2 bazel toolchains (#114) Build with envoy toolchain for bazel 3.7.2. Follow this to adopt bazel 3.7.2 for envoy upon its release then we will bump /bazelbuild/envoy/WORKSPACE to pick up bazel 3.7.2 and validate then we wait hours for all builds in flight before proceeding to add llvm 11.0.0 in Windows to a rebuild of the 3.7.2 envoy build tools alone Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
htuch
pushed a commit
that referenced
this pull request
Dec 17, 2020
[skip ci] Regenerate linux toolchains from 16d0083 [skip ci] build 3.7.2 bazel toolchains (#114) Build with envoy toolchain for bazel 3.7.2. Follow this to adopt bazel 3.7.2 for envoy upon its release then we will bump /bazelbuild/envoy/WORKSPACE to pick up bazel 3.7.2 and validate then we wait hours for all builds in flight before proceeding to add llvm 11.0.0 in Windows to a rebuild of the 3.7.2 envoy build tools alone Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build with envoy toolchain for bazel 3.7.2.
Co-authored-by: Sunjay Bhatia sunjayb@vmware.com