Step 4: Bump bazel on windows to llvm11 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is also a draft, and at this point may fail CI altogether. Steps documented above. |
wrowe
force-pushed
the
bump-bazel-llvm11
branch
from
39bacb9 to
3e12331
Compare
wrowe
commented
Dec 14, 2020
| @@ -38,7 +38,7 @@ esac | |||
|
|
|||
| # Bazel query is the right command so bazel won't fail itself. | |||
| # Keep bazel versions here at most two: current master version, next version | |||
| for BAZEL_VERSION in "3.6.0" "3.7.0"; do | |||
| for BAZEL_VERSION in "3.7.2"; do | |||
There was a problem hiding this comment.
At time of applying this patch, the transition will be from 3.6.0+3.7.2 -> only 3.7.2
because on windows, the build will fail if we attempt to regenerate 3.6.0 after upgrading llvm to 11.0.0 on windows.
- Toolchains built on our Windows docker image containing llvm 11.0.0 cannot be built for or built with any older version of bazel such as 3.6.0 - Rebased due to very confused merge. Following this build, we need to add the next target flavor of bazel, e.g. 4.0.0 as a 2nd item once again. Co-authored-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
wrowe
force-pushed
the
bump-bazel-llvm11
branch
from
3e12331 to
3f0d9c7
Compare
|
Sorry for the force push, it was quite confused by the merge to master |
lizan
approved these changes
Jan 4, 2021
htuch
pushed a commit
that referenced
this pull request
Jan 4, 2021
[skip ci] Step 4, build only 3.7.2, lets us go live with llvm 11.0.0 (#115) - Toolchains built on our Windows docker image containing llvm 11.0.0 cannot be built for or built with any older version of bazel such as 3.6.0 - Rebased due to very confused merge. Following this build, we need to add the next target flavor of bazel, e.g. 4.0.0 as a 2nd item once again. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
htuch
pushed a commit
that referenced
this pull request
Jan 4, 2021
[skip ci] Regenerate linux toolchains from 11efa56 [skip ci] Step 4, build only 3.7.2, lets us go live with llvm 11.0.0 (#115) - Toolchains built on our Windows docker image containing llvm 11.0.0 cannot be built for or built with any older version of bazel such as 3.6.0 - Rebased due to very confused merge. Following this build, we need to add the next target flavor of bazel, e.g. 4.0.0 as a 2nd item once again. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build bazel 3.7.2, Windows llvm 11.0.0-based toolchain
Co-authored-by: Sunjay Bhatia sunjayb@vmware.com