Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Linux clang 11 bump #119

Merged
merged 8 commits into from
Jan 28, 2021
Merged

Redo Linux clang 11 bump #119

merged 8 commits into from
Jan 28, 2021

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Dec 18, 2020

Reapplies #116 which had to be reverted as it was merged too early

Also bumps Windows LLVM to 11.0.1 and adds Bazel 4.0.0 toolchain generation

@sunjayBhatia sunjayBhatia marked this pull request as draft December 18, 2020 20:31
@wrowe wrowe marked this pull request as ready for review December 18, 2020 20:59
This reverts commit f7e4096.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner December 18, 2020 21:01
@sunjayBhatia sunjayBhatia changed the title Redo clang 11 Redo Linux clang 11 Dec 18, 2020
@wrowe
Copy link
Contributor

wrowe commented Dec 18, 2020

Let's expect to sync this update with #115

@wrowe
Copy link
Contributor

wrowe commented Jan 4, 2021

/retest

I might not have perms to do this, @sunjayBhatia

sunjayBhatia and others added 2 commits January 4, 2021 16:42
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia
Copy link
Member Author

Looks like the 11.0.0 16.04 binaries are not on the releases page anymore, will need to update to 20.04

@wrowe
Copy link
Contributor

wrowe commented Jan 4, 2021

the 11.0.0 16.04 binaries are not on the releases page anymore

A compromise position would be to bump to 18.04, but I think it's a little late for that. Good call, time to jump to this decade.

Base automatically changed from master to main January 15, 2021 23:19
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia changed the title Redo Linux clang 11 Redo Linux clang 11 bump Jan 25, 2021
@sunjayBhatia
Copy link
Member Author

cc @lizan this is green if you get a chance to look

Copy link
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pick up 11.0.1 windows and mac at the same time and begin keeping these in-sync?

Should we pick back up bazel 4.0.0+3.7.2 in the process?

lizan
lizan previously approved these changes Jan 25, 2021
@lizan
Copy link
Member

lizan commented Jan 25, 2021

yeah since bazel 4.0 is released let's pick up it.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@wrowe wrowe merged commit edbec0b into envoyproxy:main Jan 28, 2021
@sunjayBhatia sunjayBhatia deleted the redo-clang-11 branch January 28, 2021 22:23
htuch pushed a commit that referenced this pull request Jan 28, 2021
  [skip ci]
  Update toolchains to llvm 11.0.1 and bazel 4.0.0 (#119)

* Revert revert of "use LLVM 11 (#116)"
* Bump to LLVM 11.0.1 on Linux and Windows
* Generate bazel 4.0.0 toolchains

Authored-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
htuch pushed a commit that referenced this pull request Jan 28, 2021
  [skip ci]
  Regenerate linux toolchains from edbec0b

  [skip ci]
  Update toolchains to llvm 11.0.1 and bazel 4.0.0 (#119)

* Revert revert of "use LLVM 11 (#116)"
* Bump to LLVM 11.0.1 on Linux and Windows
* Generate bazel 4.0.0 toolchains

Authored-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants