Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploys to Maven/Sonatype are broken #2524

Closed
jpsim opened this issue Sep 6, 2022 · 2 comments · Fixed by #2526
Closed

Deploys to Maven/Sonatype are broken #2524

jpsim opened this issue Sep 6, 2022 · 2 comments · Fixed by #2526
Assignees
@jpsim
Labels
bug Something isn't working ci

Comments

@jpsim
Copy link
Contributor

jpsim commented Sep 6, 2022

Unable to create staging id

See: https://github.com/envoyproxy/envoy-mobile/runs/8189701207?check_suite_focus=true
@jpsim jpsim added the ci label Sep 6, 2022
@jpsim jpsim self-assigned this Sep 6, 2022
@jpsim jpsim added the bug Something isn't working label Sep 6, 2022
@jpsim
Copy link
Contributor Author

jpsim commented Sep 6, 2022

The credentials defined on CI still work to log in to https://oss.sonatype.org so I can rule that out.

@jpsim
Copy link
Contributor Author

jpsim commented Sep 6, 2022

I believe this is the error:

'Request' object has no attribute 'add_data'

Referring to this line:

envoy-mobile/ci/sonatype_nexus_upload.py

Line 120 in 25344a6

request.add_data(json.dumps(data))

jpsim added a commit that referenced this issue Sep 6, 2022
@jpsim
ci: fix Sonatype deploys
95d463c 
Fixes #2524

Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim mentioned this issue Sep 6, 2022
Merged
jpsim added a commit that referenced this issue Sep 6, 2022
@jpsim
ci: fix Sonatype deploys (#2526)
9aa73d6 
Fixes #2524

Signed-off-by: JP Simard <jp@jpsim.com>
colibie pushed a commit to colibie/envoy-mobile that referenced this issue Sep 21, 2022
@jpsim @colibie
ci: fix Sonatype deploys (envoyproxy#2526)
6ba059a 
Fixes envoyproxy#2524

Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Chidera Olibie <colibie@google.com>
jpsim added a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@jpsim
ci: fix Sonatype deploys (#2526)
b8b300b 
Fixes envoyproxy/envoy-mobile#2524

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpsim jpsim

Labels
bug Something isn't working ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix Sonatype deploys envoyproxy/envoy-mobile
1 participant
@jpsim