-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please support domain matching in the CORS config #2526
Labels
Comments
SGTM if anyone would like to work on this. |
@codesuki in case he's interested :-) |
I am down for it. This is a feature I wanted to implement in the beginning. But the earliest I could start to work on it is middle to end of March. So if nobody picks it up until then, I will. |
codesuki
added a commit
to codesuki/envoy
that referenced
this issue
Jul 1, 2018
Resolves envoyproxy#2526 Signed-off-by: Neri Marschik <codesuki@users.noreply.github.com>
mattklein123
pushed a commit
that referenced
this issue
Jul 10, 2018
Resolves #2526 Signed-off-by: Neri Marschik <codesuki@users.noreply.github.com>
mattklein123
pushed a commit
to envoyproxy/data-plane-api
that referenced
this issue
Jul 10, 2018
Resolves envoyproxy/envoy#2526 Signed-off-by: Neri Marschik <codesuki@users.noreply.github.com> Mirrored from https://github.com/envoyproxy/envoy @ 00bb039a78f66b7cd42acedd9b2d3dc52bfb605d
jpsim
added a commit
that referenced
this issue
Nov 28, 2022
Fixes envoyproxy/envoy-mobile#2524 Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this issue
Nov 29, 2022
Fixes envoyproxy/envoy-mobile#2524 Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
The
envoy.cors
filter injects CORS headers. Currently the outgoingAccess-Control-Allow-Origin
header is set from a hardcoded set of domains in the Envoy config, so you must know the string-exact name of each domain that will be making requests to the service.It'd be nice if Envoy could support matching (regex, wildcard, or whatever) on the incoming
Origin
header. If a match is found, then the outgoingAccess-Control-Allow-Origin
would be set to the origin as provided by the client.This would let CORS be useful for sites on dynamically-generated domain names, for example when using a temporary website instance allocated per Github PR.
Relevant Links:
Access-Control-Allow-Origin: *
has security implications, so we'd like to avoid it.The text was updated successfully, but these errors were encountered: