Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Re-enable engflow for kotlin tests #2071

Merged
merged 14 commits into from
Mar 1, 2022
Merged

Conversation

lfpino
Copy link
Contributor

@lfpino lfpino commented Feb 22, 2022

Signed-off-by: Luis Fernando Pino Duque luis@engflow.com

Description:
Re-enable engflow for kotlin tests by using JDK 8 and allowing pulse_client_impl_test and engine_builder_test to run without a sandbox. Those tests are trying to access a path under "/var/folders/wp/..." as part of one of the mock initializations, however, the sandbox doesn't allow that. The real fix will come next where we add those paths to the allow-list

Risk Level: Low
Testing: See android_tests workflow
Docs Changes: N/A
Release Notes: N/A
Fixes #2020

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino lfpino marked this pull request as ready for review February 24, 2022 10:52
@lfpino
Copy link
Contributor Author

lfpino commented Feb 24, 2022

@jpsim could you please take a look?

Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real fix will come next where we add those paths to the allow-list

Sounds right, looking forward to it.


These changes look good to me in the short term.

@jpsim
Copy link
Contributor

jpsim commented Feb 28, 2022

@lfpino looks like the java_tests_mac job is repeatedly failing with the following errors:

/private/var/lib/engflow/worker/work/7/exec/bazel-out/darwin-fastbuild/bin/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test.runfiles/envoy_mobile/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test: line 260: fg: no job control
/private/var/lib/engflow/worker/work/7/exec/bazel-out/darwin-fastbuild/bin/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test.runfiles/envoy_mobile/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test: line 261: fg: no job control
/private/var/lib/engflow/worker/work/7/exec/bazel-out/darwin-fastbuild/bin/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test.runfiles/envoy_mobile/test/java/io/envoyproxy/envoymobile/engine/jvm_bridge_utility_test: line 262: fg: no job control
JUnit4 Test Runner
.....
Time: 0.139

OK (5 tests)


BazelTestRunner exiting with a return value of 0
JVM shutdown hooks (if any) will run now.
The JVM will exit once they complete.

-- JVM shutdown starting at 2022-02-28 16:26:10 --

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino
Copy link
Contributor Author

lfpino commented Mar 1, 2022

@jpsim I think that was a flake, could you please merge? If you see the flake again please open an issue and I'll investigate

@jpsim
Copy link
Contributor

jpsim commented Mar 1, 2022

If you see the flake again please open an issue and I'll investigate

will do

@jpsim jpsim merged commit 66ce0b5 into envoyproxy:main Mar 1, 2022
goaway added a commit that referenced this pull request Mar 1, 2022
This reverts commit 66ce0b5.

Signed-off-by: Mike Schore <mike.schore@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Run integration tests on EngFlow
2 participants