-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Re-enable engflow for kotlin tests #2071
Conversation
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@jpsim could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real fix will come next where we add those paths to the allow-list
Sounds right, looking forward to it.
These changes look good to me in the short term.
@lfpino looks like the java_tests_mac job is repeatedly failing with the following errors:
|
@jpsim I think that was a flake, could you please merge? If you see the flake again please open an issue and I'll investigate |
will do |
This reverts commit 66ce0b5. Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Luis Fernando Pino Duque luis@engflow.com
Description:
Re-enable engflow for kotlin tests by using JDK 8 and allowing pulse_client_impl_test and engine_builder_test to run without a sandbox. Those tests are trying to access a path under "/var/folders/wp/..." as part of one of the mock initializations, however, the sandbox doesn't allow that. The real fix will come next where we add those paths to the allow-list
Risk Level: Low
Testing: See android_tests workflow
Docs Changes: N/A
Release Notes: N/A
Fixes #2020