Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run integration tests on EngFlow #2020

Closed
jpsim opened this issue Jan 25, 2022 · 3 comments · Fixed by #2022 or #2071
Closed

[CI] Run integration tests on EngFlow #2020

jpsim opened this issue Jan 25, 2022 · 3 comments · Fixed by #2022 or #2071

Comments

@jpsim
Copy link
Contributor

jpsim commented Jan 25, 2022

In #1995 I disabled remote execution for the integration test CI jobs because of test failures that were only occurring when using remote execution but ran fine on GitHub Actions workers directly.

Here's the kind of failure we were seeing when running these tests with remote execution: https://github.com/envoyproxy/envoy-mobile/runs/4739746396?check_suite_focus=true

And the same tests running successfully without remote execution: https://github.com/envoyproxy/envoy-mobile/runs/4740616118?check_suite_focus=true

@lfpino
Copy link
Contributor

lfpino commented Jan 25, 2022

We have an easy fix for this one. @WillEngFlow will send you a PR in a bit.

@jpsim
Copy link
Contributor Author

jpsim commented Feb 4, 2022

The tests in test/common/integration/BUILD were re-enabled on EngFlow in #2022, but the tests in test/swift/integration/BUILD still have no-remote-exec so I'm reopening this ticket to track that.

@lfpino
Copy link
Contributor

lfpino commented Feb 25, 2022

This will be fixed with #2071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants