Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Kotlin macOS tests without EngFlow #2018

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Jan 25, 2022

These jobs fail when run with remote execution but pass when run directly on GitHub Actions agents.

Signed-off-by: JP Simard jp@jpsim.com

@jpsim
Copy link
Contributor Author

jpsim commented Jan 25, 2022

The android_tests / kotlin_tests_mac job is now passing:

//test/kotlin/io/envoyproxy/envoymobile:engine_builder_test              PASSED in 5.9s
//test/kotlin/io/envoyproxy/envoymobile:grpc_request_headers_builder_test PASSED in 2.7s
//test/kotlin/io/envoyproxy/envoymobile:grpc_stream_test                 PASSED in 2.4s
//test/kotlin/io/envoyproxy/envoymobile:headers_builder_test             PASSED in 2.3s
//test/kotlin/io/envoyproxy/envoymobile:pulse_client_impl_test           PASSED in 5.8s
//test/kotlin/io/envoyproxy/envoymobile:request_headers_builder_test     PASSED in 3.1s
//test/kotlin/io/envoyproxy/envoymobile:response_headers_test            PASSED in 2.6s
//test/kotlin/io/envoyproxy/envoymobile:retry_policy_mapper_test         PASSED in 1.1s
//test/kotlin/io/envoyproxy/envoymobile/stats:element_test               PASSED in 2.2s
//test/kotlin/io/envoyproxy/envoymobile/stats:tags_builder_test          PASSED in 2.3s

It seems increasingly likely that something in the remote execution environment is responsible for these test failures.

@lfpino how can we troubleshoot CI failures that only happen with EngFlow remote execution?

To investigate a failing CI job.

Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim force-pushed the run-kotlin-macos-tests-without-engflow branch from 5475e2d to 7501ac3 Compare January 25, 2022 19:59
Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim force-pushed the run-kotlin-macos-tests-without-engflow branch from a2d3845 to 7d19a7a Compare January 25, 2022 20:03
@lfpino
Copy link
Contributor

lfpino commented Jan 25, 2022

What kind of failure are you observing? Is it similar to #2007?

If you're suspecting an Engflow infrastructure failure please page us using envoy-vyuw3pbm@engflow.pagerduty.com and our oncall will get on it.

Can you please open an issue in the meantime with some of the failure links and I'll take a look?

@jpsim
Copy link
Contributor Author

jpsim commented Jan 25, 2022

Can you please open an issue in the meantime with some of the failure links and I'll take a look?

Sure, I'll open two issues actually, one for this and another for the integration tests which I also had to disable similarly.

@jpsim
Copy link
Contributor Author

jpsim commented Jan 25, 2022

@lfpino I've filed #2019 & #2020 for the two situations in which we've had to disable remote execution due to test failures. If you'd like me to send an email to the pager duty address to trigger your on-call process I'm happy to do that, but as of this PR these two issues are mitigated so it's not urgent from our perspective.

@lfpino
Copy link
Contributor

lfpino commented Jan 25, 2022

Thanks @jpsim, I'll take a look so no need to page the oncall, even if it's not urgent, this isn't ideal so let's make sure we can fix it back in Engflow soon.

@goaway goaway merged commit 957bf7e into envoyproxy:main Jan 27, 2022
@jpsim jpsim deleted the run-kotlin-macos-tests-without-engflow branch January 27, 2022 18:14
jpsim added a commit to jpsim/envoy-mobile that referenced this pull request Feb 3, 2022
* origin/main: (21 commits)
  owners: adding charles (envoyproxy#2038)
  [OWNERS] Update Envoy Mobile owners (envoyproxy#2031)
  [deps] Update rules_android to a stable release URL (envoyproxy#2032)
  [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030)
  Enable the "received byte count" feature. (envoyproxy#2004)
  Run Kotlin macOS tests without EngFlow (envoyproxy#2018)
  final_intel: adding response flags (envoyproxy#2009)
  fix (envoyproxy#2025)
  stream intel: update kotlin public interface to align with swift (envoyproxy#2013)
  tls: update bundled root certificates (envoyproxy#2016)
  tooling: first pass at oncall tooling (envoyproxy#2014)
  test: Solve CI flakiness for test/java/org/chromium/net/urlconnection:urlconnection_test  (envoyproxy#2007)
  envoy: 519774f742 (envoyproxy#2015)
  Default timestamp to -1 for envoy_final_stream_intel (envoyproxy#2006)
  QuicTestServer (envoyproxy#1989)
  bump boringssl to Envoy's version (envoyproxy#1999)
  docs: addding release notes (envoyproxy#2001)
  release: cutting the 0.4.5 release (envoyproxy#2000)
  Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)" (envoyproxy#1998)
  Decompress even when `no-transform` is specified (envoyproxy#1995)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants