-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: change bazelisk for M1 support #1966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You already know this but documenting anyway this depends on #1962 |
This should work when rebased. |
jpsim
previously approved these changes
Dec 15, 2021
keith
force-pushed
the
ks/bazel-change-bazelisk-for-m1-support
branch
from
December 15, 2021 19:03
8b3eadb
to
db45c48
Compare
jpsim
previously approved these changes
Dec 15, 2021
This uses a fat binary version of bazelisk to better support arm bazel Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
force-pushed
the
ks/bazel-change-bazelisk-for-m1-support
branch
from
January 6, 2022 21:15
db45c48
to
9ae64d8
Compare
jpsim
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me in my testing on an M1 Mac mini.
buildbreaker
approved these changes
Jan 7, 2022
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Jan 7, 2022
This reverts commit fa75a60. Signed-off-by: JP Simard <jp@jpsim.com>
buildbreaker
pushed a commit
that referenced
this pull request
Jan 7, 2022
This reverts commit fa75a60. Unfortunately still not working on M1. E.g. ``` $ ./bazelw build //library/common:envoy_main_interface_lib ERROR: While resolving toolchains for target @com_envoyproxy_protoc_gen_validate//:protoc-gen-validate: no matching toolchains found for types @io_bazel_rules_go//go:toolchain ERROR: Analysis of target '//library/common:envoy_main_interface_lib' failed; build aborted: no matching toolchains found for types @io_bazel_rules_go//go:toolchain ```
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Feb 3, 2022
* origin/main: (21 commits) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030) Enable the "received byte count" feature. (envoyproxy#2004) Run Kotlin macOS tests without EngFlow (envoyproxy#2018) final_intel: adding response flags (envoyproxy#2009) fix (envoyproxy#2025) stream intel: update kotlin public interface to align with swift (envoyproxy#2013) tls: update bundled root certificates (envoyproxy#2016) tooling: first pass at oncall tooling (envoyproxy#2014) test: Solve CI flakiness for test/java/org/chromium/net/urlconnection:urlconnection_test (envoyproxy#2007) envoy: 519774f742 (envoyproxy#2015) Default timestamp to -1 for envoy_final_stream_intel (envoyproxy#2006) QuicTestServer (envoyproxy#1989) bump boringssl to Envoy's version (envoyproxy#1999) docs: addding release notes (envoyproxy#2001) release: cutting the 0.4.5 release (envoyproxy#2000) Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)" (envoyproxy#1998) Decompress even when `no-transform` is specified (envoyproxy#1995) ... Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a fat binary version of bazelisk to better support arm bazel
Signed-off-by: Keith Smiley keithbsmiley@gmail.com