Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "bazel: change bazelisk for M1 support (#1966)" #1998

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Revert "bazel: change bazelisk for M1 support (#1966)" #1998

merged 1 commit into from
Jan 7, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Jan 7, 2022

This reverts commit fa75a60.

Unfortunately still not working on M1.

E.g.

$ ./bazelw build //library/common:envoy_main_interface_lib
ERROR: While resolving toolchains for target @com_envoyproxy_protoc_gen_validate//:protoc-gen-validate: no matching toolchains found for types @io_bazel_rules_go//go:toolchain
ERROR: Analysis of target '//library/common:envoy_main_interface_lib' failed; build aborted: no matching toolchains found for types @io_bazel_rules_go//go:toolchain

@jpsim
Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)"
09030ff 
This reverts commit fa75a60.

Signed-off-by: JP Simard <jp@jpsim.com>
@buildbreaker buildbreaker merged commit 4710ef4 into envoyproxy:main Jan 7, 2022
@jpsim jpsim deleted the revert-bazel-change-bazelisk-for-m1-support-1966 branch January 7, 2022 21:39
jpsim added a commit to jpsim/envoy-mobile that referenced this pull request Feb 3, 2022
@jpsim
Merge remote-tracking branch 'origin/main' into xcode-13.2.1
9797331 
* origin/main: (21 commits)
  owners: adding charles (envoyproxy#2038)
  [OWNERS] Update Envoy Mobile owners (envoyproxy#2031)
  [deps] Update rules_android to a stable release URL (envoyproxy#2032)
  [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030)
  Enable the "received byte count" feature. (envoyproxy#2004)
  Run Kotlin macOS tests without EngFlow (envoyproxy#2018)
  final_intel: adding response flags (envoyproxy#2009)
  fix (envoyproxy#2025)
  stream intel: update kotlin public interface to align with swift (envoyproxy#2013)
  tls: update bundled root certificates (envoyproxy#2016)
  tooling: first pass at oncall tooling (envoyproxy#2014)
  test: Solve CI flakiness for test/java/org/chromium/net/urlconnection:urlconnection_test  (envoyproxy#2007)
  envoy: 519774f742 (envoyproxy#2015)
  Default timestamp to -1 for envoy_final_stream_intel (envoyproxy#2006)
  QuicTestServer (envoyproxy#1989)
  bump boringssl to Envoy's version (envoyproxy#1999)
  docs: addding release notes (envoyproxy#2001)
  release: cutting the 0.4.5 release (envoyproxy#2000)
  Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)" (envoyproxy#1998)
  Decompress even when `no-transform` is specified (envoyproxy#1995)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buildbreaker buildbreaker buildbreaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpsim @buildbreaker