Fixed network policy of client_integration_test

[WillEngFlow]

//test/common/integration:client_integration_test requires networking
which is not allowed by default. This allows the test to use the
localhost network.

Signed-off-by: Will will@engflow.com

Description: //test/common/integration:client_integration_test requires networking which is not allowed by default. This allows the test to use the localhost network.
Risk Level: Low
Testing: See unit_tests workflow
Docs Changes: N/A
Release Notes: N/A
Fixes #2020

[WillEngFlow]

@jpsim @goaway @lfpino

[goaway]

Thanks @WillEngFlow!

[WillEngFlow]

@jpsim It looks like this is failing because the exec_properties attribute does not exist on envoy_cc_test upstream. Do you mind adding it for me and piping it into the wrapped cc_test?

envoy_cc_test defined here: https://github.com/envoyproxy/envoy/blob/519774f742bb2500cf5f6a00933c9662337acbb2/bazel/envoy_test.bzl#L143

An example of piping exec_properties through via 'envoy_mobile_jni_kt_test`:

envoy-mobile/bazel/kotlin_test.bzl

Line 4 in cef4ec0

def _internal_kt_test(name, srcs, deps = [], data = [], jvm_flags = [], repository = "", exec_properties = {}):

[jpsim]

Sure I'll plumb that through and see if it helps. I'll do the same for the Swift integration test that similarly had remote exec disabled.

[jpsim]

[bazel] allow specifying exec_properties in envoy_cc_test

[jpsim]

I've validated that it works: https://github.com/envoyproxy/envoy-mobile/runs/4959253557

My upstream Envoy PR (envoyproxy/envoy#19711) was approved and is being auto-merged. Once that's in, I'll bump the Envoy submodule commit to point to it and you'll be able to rebase this PR.

[jpsim]

#2027

[WillEngFlow]

#2027

Thanks for all the work @jpsim! I'm tracking the submodule update.

[jpsim]

I just merged #2027 so if you update, you should be able to pass exec_properties in envoy_cc_test.

[WillEngFlow]

I just merged #2027 so if you update, you should be able to pass exec_properties in envoy_cc_test.

Thanks @jpsim! I just pushed the most recent fix. I did get some linter errors on the WORKSPACE file after rebasing (in the pre-push check) but no changes were made to WORKSPACE and my changes checked out so I pushed with --no-verify

[jpsim]

@WillEngFlow i also often get errors in the pre-push hook, but pre-commit run --all-files works. I need to look into fixing that at some point.

in this case, I think the BUILD file you edited needs to move the attribute to match the definition.

[jpsim]

Thanks for seeing this through!

[WillEngFlow]

Thanks for seeing this through!

Thanks for all the help for a first time contributor!