Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] allow specifying exec_properties in envoy_cc_test #19711

Merged
merged 1 commit into from
Jan 27, 2022
Merged

[bazel] allow specifying exec_properties in envoy_cc_test #19711

merged 1 commit into from
Jan 27, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Jan 26, 2022

Commit Message: [bazel] allow specifying exec_properties in envoy_cc_test
Additional Description: In order to pass properties such as sandboxNetwork as we are trying to do in Envoy Mobile here: envoyproxy/envoy-mobile#2022
Risk Level: Low

In order to pass properties such as `sandboxNetwork` as we are trying to
do in Envoy Mobile here: envoyproxy/envoy-mobile#2022

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit to jpsim/envoy-mobile that referenced this pull request Jan 26, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit to jpsim/envoy-mobile that referenced this pull request Jan 26, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit to jpsim/envoy-mobile that referenced this pull request Jan 26, 2022
Signed-off-by: JP Simard <jp@jpsim.com>
@lizan lizan enabled auto-merge (squash) January 26, 2022 23:51
@jpsim
Copy link
Contributor Author

jpsim commented Jan 27, 2022

Thanks @lizan!

@lizan lizan merged commit 71248e5 into envoyproxy:main Jan 27, 2022
@jpsim jpsim deleted the cc_test_exec_properties branch January 27, 2022 00:56
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
…roxy#19711)

In order to pass properties such as `sandboxNetwork` as we are trying to do in Envoy Mobile here: envoyproxy/envoy-mobile#2022
Risk Level: Low

Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants