Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: expose env variables to Wasm VMs through environ_get WASI interface #14958

Closed
mathetake opened this issue Feb 5, 2021 · 5 comments · Fixed by #15136
Closed

wasm: expose env variables to Wasm VMs through environ_get WASI interface #14958

mathetake opened this issue Feb 5, 2021 · 5 comments · Fixed by #15136
Assignees
Labels
area/wasm design proposal Needs design doc/proposal before implementation enhancement Feature requests. Not bugs or questions.

Comments

@mathetake
Copy link
Member

mathetake commented Feb 5, 2021

Reading env variables from inside Wasm VMs are already defined in WASI's environ_get functions, and well supported in various compiler toolchains. However the current implementation of proxy-wasm-cpp-host and envoy does not expose any value to a VM.

There are strong demands from the community for supporting this, and it makes sense to add the new configuration in the Wasm filter's extension to control which variables should be exposed to the Wasm VM.

ref: proxy-wasm/spec#19

@antoniovicente
Copy link
Contributor

cc @PiotrSikora @lizan

@antoniovicente antoniovicente added the design proposal Needs design doc/proposal before implementation label Feb 8, 2021
@antoniovicente
Copy link
Contributor

Do you have a specific proposal in mind? cc'ing other folks involved in WASM integration.

@antoniovicente antoniovicente removed the triage Issue requires triage label Feb 8, 2021
@PiotrSikora
Copy link
Contributor

This is already part of WASI spec (see discussion in proxy-wasm/spec#19). The only missing piece is Envoy implementation and exposing it in the configuration.

@antoniovicente antoniovicente added the help wanted Needs help! label Feb 8, 2021
@antoniovicente
Copy link
Contributor

What are the next steps?

  • Do we need any consensus building before implementation can start?
  • Is someone on the hook to do the Envoy implementation?

@antoniovicente antoniovicente removed the help wanted Needs help! label Feb 8, 2021
@PiotrSikora
Copy link
Contributor

Consensus has been reached. @mathetake is already working on it proxy-wasm/proxy-wasm-cpp-host#126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wasm design proposal Needs design doc/proposal before implementation enhancement Feature requests. Not bugs or questions.
Projects
None yet
3 participants