WasmPlugin add VmConfig #2227
Merged
WasmPlugin add VmConfig #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
zirain
requested review from
ericvn,
howardjohn,
linsun,
louiscryan,
nrjpoddar and
smawson
as code owners
istio-testing
removed
the
do-not-merge/work-in-progress
hzxuzhonghu
reviewed
Jan 27, 2022
zirain
force-pushed
the
wasmplugin-vmconfig
branch
from
36f32b9 to
2a64590
Compare
zirain
force-pushed
the
wasmplugin-vmconfig
branch
from
2a64590 to
2efcabf
Compare
istio-testing
added
size/S
zirain
force-pushed
the
wasmplugin-vmconfig
branch
from
2efcabf to
1677940
Compare
|
release notes will add when implemented in istio repo |
zirain
added
the
release-notes-none
|
/retest-required |
|
/test release-notes_api |
zirain
force-pushed
the
wasmplugin-vmconfig
branch
from
6b464d6 to
2ded56d
Compare
bianpengyuan
previously approved these changes
Jan 28, 2022
howardjohn
reviewed
Jan 31, 2022
zirain
force-pushed
the
wasmplugin-vmconfig
branch
from
2ded56d to
3bab299
Compare
istio-testing
added
size/M
zirain
force-pushed
the
wasmplugin-vmconfig
branch
from
3bab299 to
bff2ca5
Compare
|
@bianpengyuan @howardjohn ptal |
howardjohn
reviewed
Feb 7, 2022
zirain
force-pushed
the
wasmplugin-vmconfig
branch
2 times, most recently
from
7bd9896 to
07d34fb
Compare
|
blocked by #2235 |
|
/test gencheck_api |
|
updated, @howardjohn @bianpengyuan ptal |
howardjohn
approved these changes
Feb 9, 2022
| // imagePullSecret: private-registry-pull-secret | ||
| // phase: AUTHN | ||
| // pluginConfig: | ||
| // openid_server: authn |
There was a problem hiding this comment.
when should a user use pluginConfig vs vmConfig?
There was a problem hiding this comment.
vm config is for the runtime configuration (i.e. code written by use), while plugin config is for the plugin (code written by user).
|
lgtm, I removed @bianpengyuan review since it was stale. @bianpengyuan can you take a look to make sure its good? Thanks! |
bianpengyuan
reviewed
Feb 9, 2022
zirain
force-pushed
the
wasmplugin-vmconfig
branch
from
202e721 to
393086c
Compare
bianpengyuan
approved these changes
Feb 10, 2022
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envoyproxy/envoy#14958 is merged
add
VmConfigsupport get env in wasm extensions@bianpengyuan @mathetake PTAL