Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Wasmplugin vmconfig #37227

Merged
merged 5 commits into from
Feb 11, 2022
Merged

support Wasmplugin vmconfig #37227

merged 5 commits into from
Feb 11, 2022

Conversation

zirain
Copy link
Member

@zirain zirain commented Feb 9, 2022 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

implement of WasmPlugin.VmConfig

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 9, 2022
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2022
@zirain zirain force-pushed the wasmplugin-vmconfig branch from 9dbd6ab to 7eebf96 Compare February 9, 2022 06:31
@zirain
Copy link
Member Author

zirain commented Feb 9, 2022

wait istio/api#2227

@zirain zirain force-pushed the wasmplugin-vmconfig branch from 7eebf96 to 6e6831d Compare February 10, 2022 06:36
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 10, 2022
@zirain zirain force-pushed the wasmplugin-vmconfig branch from 6e6831d to 699cd1d Compare February 10, 2022 07:10
@zirain zirain marked this pull request as ready for review February 10, 2022 07:11
@zirain zirain requested review from a team as code owners February 10, 2022 07:11
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 10, 2022
@zirain
Copy link
Member Author

zirain commented Feb 10, 2022

@bianpengyuan request for a review.

@zirain zirain requested a review from bianpengyuan February 10, 2022 07:12
bianpengyuan
bianpengyuan reviewed Feb 10, 2022
View reviewed changes
pilot/pkg/model/extensions.go Outdated Show resolved Hide resolved
pkg/config/validation/validation.go Outdated Show resolved Hide resolved
pkg/config/validation/validation.go Outdated Show resolved Hide resolved
releasenotes/notes/37227.yaml Outdated Show resolved Hide resolved
hzxuzhonghu
hzxuzhonghu reviewed Feb 10, 2022
View reviewed changes
pilot/pkg/model/extensions.go Outdated Show resolved Hide resolved
pilot/pkg/model/extensions.go Outdated Show resolved Hide resolved
@zirain
Copy link
Member Author

zirain commented Feb 11, 2022

/test integ-pilot-multicluster_istio

@istio-testing istio-testing merged commit ffb9329 into istio:master Feb 11, 2022
@zirain zirain mentioned this pull request Feb 15, 2022
Merged
5 tasks
@zirain zirain deleted the wasmplugin-vmconfig branch March 24, 2022 06:19
@zirain zirain mentioned this pull request Jun 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@bianpengyuan bianpengyuan bianpengyuan approved these changes

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Assignees
No one assigned
Labels
area/extensions and telemetry size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zirain @istio-testing @howardjohn @hzxuzhonghu @bianpengyuan