Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc version error #2235

Closed
zirain opened this issue Feb 8, 2022 · 2 comments · Fixed by #2236
Closed

protoc version error #2235

zirain opened this issue Feb 8, 2022 · 2 comments · Fixed by #2236
Labels
area/test and release

Comments

@zirain
Copy link
Member

zirain commented Feb 8, 2022

Bug description

protoc version change to unknow after make gen

image

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
@howardjohn
Copy link
Member

This is intended from istio/tools@250e4c4. but it was supposed to run make gen and commit it, so we need to do it manually I guess. Not sure why it did not do it automatically

@zirain
Copy link
Member Author

zirain commented Feb 8, 2022

This is intended from istio/tools@250e4c4. but it was supposed to run make gen and commit it, so we need to do it manually I guess. Not sure why it did not do it automatically

protoc version seems incorrect after manual run make gen

howardjohn added a commit to howardjohn/api that referenced this issue Feb 8, 2022
@howardjohn
Re-run gen after buf upgrade
b15483c 
This was an intended change in `buf` to not set the protoc version. I
don't know the context. Fixes istio#2235
@howardjohn howardjohn mentioned this issue Feb 8, 2022
Merged
@zirain zirain mentioned this issue Feb 8, 2022
Merged
istio-testing pushed a commit that referenced this issue Feb 8, 2022
@howardjohn
Re-run gen after buf upgrade (#2236)
49eaa21 
This was an intended change in `buf` to not set the protoc version. I
don't know the context. Fixes #2235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test and release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-run gen after buf upgrade howardjohn/api
3 participants
@howardjohn @zirain @istio-policy-bot