Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_top_level_ecds_stats deprecation #23604

Closed
alyssawilk opened this issue Oct 20, 2022 · 0 comments · Fixed by #23611
Closed

envoy_reloadable_features_top_level_ecds_stats deprecation #23604

alyssawilk opened this issue Oct 20, 2022 · 0 comments · Fixed by #23611
Assignees
@kyessenov
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #20396 (ecds: use top level stats prefix) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Oct 20, 2022
@kyessenov kyessenov mentioned this issue Oct 20, 2022
Merged
kyessenov added a commit that referenced this issue Nov 3, 2022
@kyessenov
ecds: deprecate top-level stats guard (#23611)
d93afd7 
Signed-off-by: Kuat Yessenov kuat@google.com

Commit Message: Deprecate and remove stats prefix guard for ECDS.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes: yes
Fixes: #23604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyessenov kyessenov

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ecds: deprecate top-level stats guard kyessenov/envoy
2 participants
@kyessenov @alyssawilk