ecds: deprecate top-level stats guard

[kyessenov]

Signed-off-by: Kuat Yessenov kuat@google.com

Commit Message: Deprecate and remove stats prefix guard for ECDS.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes: yes
Fixes: #23604

[kyessenov]

Flake #23618
/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23611 (comment) was created by @kyessenov.

see: more, trace.

[wbpcode]

/assign @jmarantz

[jmarantz]

/assign-from @envoyproxy/senior-maintainers

[repokitteh-read-only]

@envoyproxy/senior-maintainers assignee is @lizan

🐱

Caused by: a #23611 (review) was submitted by @jmarantz.

see: more, trace.

[jmarantz]

needs main merge

/wait

[jmarantz]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #23611 (comment) was created by @jmarantz.

see: more, trace.

[jmarantz]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #23611 (comment) was created by @jmarantz.

see: more, trace.

[kyessenov]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23611 (comment) was created by @kyessenov.

see: more, trace.

[jmarantz]

needs main merge; then we should be good to go.

[jmarantz]

/wait

[jmarantz]

sorry need to merge main again. I'll try to check back after you do it and merge before we get another conflict.

[jmarantz]

/wait

[jmarantz]

docs failure looks real. snippet:

yaml.parser.ParserError: while parsing a block mapping
  in "<unicode string>", line 1, column 1:
    date: Pending
    ^
expected <block end>, but found '-'
  in "<unicode string>", line 67, column 1:
    - area: eds
    ^
"""

[kyessenov]

@jmarantz Thanks, git merge did a bad merge, manually fixed it.

[kyessenov]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23611 (comment) was created by @kyessenov.

see: more, trace.

[jmarantz]

please ping me if you see this passes so I can merge before it grows another conflict on the release notes.

[kyessenov]

@jmarantz I should be able to merge it with your approval.

[kyessenov]

"abandoned" coverage job, restarting