Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove java_generic_services option from service proto files #25172

Closed
scrocquesel opened this issue Jan 25, 2023 · 4 comments · Fixed by #25298
Closed

Remove java_generic_services option from service proto files #25172

scrocquesel opened this issue Jan 25, 2023 · 4 comments · Fixed by #25298
Labels
api enhancement Feature requests. Not bugs or questions.

Comments

@scrocquesel
Copy link
Contributor

Title: Remove java_generic_services option from service proto files

Description:
Since version 2.4.0 (2018) this option has been deprecated and such generated classes should not be used anymore (https://developers.google.com/protocol-buffers/docs/reference/java-generated?hl=en#service).
When using plugin that produce class with the same name, protoc complains about collision and failed.

Such plugins are provided by Quarkus gRPC Mutiny generator and it is not possible to generate Mutiny service from https://github.com/envoyproxy/java-control-plane/tree/main/api
@scrocquesel scrocquesel added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Jan 25, 2023
@RyanTheOptimist RyanTheOptimist added api and removed triage Issue requires triage labels Jan 27, 2023
@RyanTheOptimist
Copy link
Contributor

cc: @mattklein123

@mattklein123
Copy link
Member

cc @phlax. Seems fine to me.

@phlax
Copy link
Member

phlax commented Feb 1, 2023

this also makes sense to me - reading the links we probably do want to remove the service lines

my only apprehension is that afaict they are all/mostly set to true - so removing means a change in current (deprecated) behaviour - im not clear if there is any impact from that

@phlax
Copy link
Member

phlax commented Feb 1, 2023

@scrocquesel if you wanted to PR the necessary changes we could at least see if it gets past CI and then i guess canvass some more opinions in terms of impact

@scrocquesel scrocquesel mentioned this issue Feb 1, 2023
Merged
htuch pushed a commit that referenced this issue Feb 9, 2023
@scrocquesel
Remove option java_generic_services from proto files (#25298)
baec129 
Generic services are deprecated since protoc version 2.4.0 (2010). Protoc plugins that generates code may require that generic services are disabled, so that they can generate their own classes of the same name.

Risk Level: Low

Fixes #25172

Signed-off-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove option java_generic_services from proto files scrocquesel/envoy
4 participants
@phlax @mattklein123 @RyanTheOptimist @scrocquesel