-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove option java_generic_services from proto files #25298
Remove option java_generic_services from proto files #25298
Conversation
Hi @scrocquesel, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
e06e71e
to
d1b439b
Compare
Will need to update https://github.com/envoyproxy/envoy/blob/main/tools/protoprint/protoprint.py. @phlax since you responded to the original issue, do you want to take this PR? |
@scrocquesel thanks for raising this i think these 2 lines envoy/tools/protoprint/protoprint.py Lines 244 to 245 in eb49336
it might also need to be removed from |
Signed-off-by: Sébastien CROCQUESEL <88554524+scrocquesel@users.noreply.github.com>
d1b439b
to
23daea4
Compare
(as a side point - its generally better not to force push unless there is a reason - ie use merge over rebase and separate commits etc - it doesnt matter so much at this point - but its generally frowned upon) |
@phlax Yes, I have only searched the directive in proto files. |
/retest |
1 similar comment
/retest |
Retrying Azure Pipelines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @scrocquesel
cc @htuch @adisuissa for final api stamp
Commit Message: Remove option java_generic_services from proto files
Additional Description: Generic services are deprecated since protoc version 2.4.0 (2010). Protoc plugins that generates code may require that generic services are disabled, so that they can generate their own classes of the same name.
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Optional Fixes #25172