test: Split huge monolith mock header to speed up test compilation #11649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
|
@asraa FYI |
ahedberg
suggested changes
Jun 19, 2020
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
|
The overall build time for cluster_manager_test has been further improved to 68.689s in my build cluster by removing superfluous includes in divided headers. |
ahedberg
suggested changes
Jun 23, 2020
test/mocks/server/admin.h
Outdated
|
|
||
| #include "absl/strings/string_view.h" | ||
| #include "config_tracker.h" | ||
| #include "gmock/gmock.h" | ||
| #include "spdlog/spdlog.h" | ||
|
|
||
| using testing::NiceMock; |
There was a problem hiding this comment.
Using-declarations should only be used in .cc files. See https://google.github.io/styleguide/cppguide.html#Namespaces
test/mocks/server/config_tracker.cc
Outdated
| #include "gmock/gmock.h" | ||
| #include "gtest/gtest.h" | ||
|
|
||
| using testing::_; |
There was a problem hiding this comment.
These should be moved to inside the innermost namespace, and they should be fully-qualified. See https://abseil.io/tips/119
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
ahedberg
approved these changes
Jun 24, 2020
|
Just a nit on the PR description, the comment |
|
@sunjayBhatia Thanks for your advice. Now the PR description has been adjusted to "Related Issues" |
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Jun 25, 2020
…nvoyproxy#11649) Commit Message: Split huge monolith mock header to speed up test compilation Additional Description: `cluster_manager_test` only used a simple mock class `MockAdmin` from `test/mocks/server/mocks.h`, which is a huge mock library. After splitting, the overall build time for `cluster_manager_test` reduced from 143.481s to 82.443s in my build cluster. Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
songhu
pushed a commit
to songhu/envoy
that referenced
this pull request
Jun 25, 2020
…nvoyproxy#11649) Commit Message: Split huge monolith mock header to speed up test compilation Additional Description: `cluster_manager_test` only used a simple mock class `MockAdmin` from `test/mocks/server/mocks.h`, which is a huge mock library. After splitting, the overall build time for `cluster_manager_test` reduced from 143.481s to 82.443s in my build cluster. Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com>
This was referenced Jul 13, 2020
Merged
Merged
yashwant121
pushed a commit
to yashwant121/envoy
that referenced
this pull request
Jul 24, 2020
…nvoyproxy#11649) Commit Message: Split huge monolith mock header to speed up test compilation Additional Description: `cluster_manager_test` only used a simple mock class `MockAdmin` from `test/mocks/server/mocks.h`, which is a huge mock library. After splitting, the overall build time for `cluster_manager_test` reduced from 143.481s to 82.443s in my build cluster. Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Split huge monolith mock header to speed up test compilation
Additional Description:
cluster_manager_testonly used a simple mock classMockAdminfromtest/mocks/server/mocks.h, which is a huge mock library. After splitting, the overall build time forcluster_manager_testreduced from 143.481s to 82.443s in my build cluster.Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917