Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor header inclusion to speed up building #11952

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

foreseeable
Copy link
Contributor

Signed-off-by: Muge Chen mugechen@google.com

Refactor mock class include directive after dividing test/server/mocks.h (#11649)

Building time comparison for affected tests:

test_name before after
//test/common/upstream:cluster_factory_impl_test 97.051s 80.938s
//test/common/upstream:eds_speed_test 102.03s 75.825s
//test/common/upstream:eds_test 101.319s 77.988s
//test/common/upstream:hds_test 105.666s 74.24s
//test/common/upstream:logical_dns_cluster_test 97.184s 78.586s
//test/common/upstream:original_dst_cluster_test 116.306s 74.845s
//test/common/upstream:transport_socket_matcher_test 99.237s 67.548s
//test/common/upstream:upstream_impl_test 101.438s 82.394s

Commit Message: refactor header inclusion to speed up building
Additional Description:
Risk Level: low
Testing: exsiting tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917

\cc @ahedberg

Signed-off-by: Muge Chen <mugechen@google.com>
@foreseeable foreseeable changed the title refactor header inclusion to speed up building test: refactor header inclusion to speed up building Jul 8, 2020
@ggreenway
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for working on this.

The CI failure looks like a flake; it compiled, so I don't think this PR could be the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants