router: add dynamic metadata header formatter #11858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new header formatter acts in the opposite direction of the header-to-metadata filter. That is, it allows setting a header from what's available in a request's metadata. We need this to populate some request headers based on what was previously extracted and transformed via the header-to-metadata filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
fishcakez
reviewed
Jul 1, 2020
…ynamic-metadata-header-formatter
added 6 commits
July 6, 2020 13:16
…ynamic-metadata-header-formatter
…ynamic-metadata-header-formatter
…ynamic-metadata-header-formatter
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
…ynamic-metadata-header-formatter
…ynamic-metadata-header-formatter
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
Are you still working on this @rgs1 ? |
stale
bot
removed
the
stale
Yeah I'll clean it up today. |
added 4 commits
July 24, 2020 17:41
…ynamic-metadata-header-formatter
…ynamic-metadata-header-formatter
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
|
Failure seems unrelated btw: |
rgs1
changed the title
added 5 commits
July 27, 2020 18:24
…ynamic-metadata-header-formatter
…ynamic-metadata-header-formatter
…ynamic-metadata-header-formatter
…ynamic-metadata-header-formatter
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
zuercher
previously approved these changes
Aug 10, 2020
stale
bot
removed
the
stale
…ynamic-metadata-header-formatter
added 3 commits
August 11, 2020 11:35
…ynamic-metadata-header-formatter
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
zuercher
approved these changes
Aug 13, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 14, 2020
* master: (67 commits) logger: support log control in admin interface and command line option for Fancy Logger (envoyproxy#12369) test: fix http_timeout_integration_test flake (envoyproxy#12654) [fuzz]added an input check in writefilter fuzzer and added test cases (envoyproxy#12628) add 'explicit' restriction. (envoyproxy#12643) scoped_rds_integration_test migrate from api v2 to api v3. (envoyproxy#12633) fuzz: added fuzz test for listener filter tls_inspector (envoyproxy#12617) testing: fix multiple race conditions in simulated time tests (envoyproxy#12527) [tls] Move handshaking behavior into SslSocketInfo. (envoyproxy#12571) header: getting rid of exception-throwing behaviors in header files [the rest] (envoyproxy#12611) router: add new ratelimited retry backoff strategy (envoyproxy#12202) [redis_proxy] added a constraint for route.prefix().size() (envoyproxy#12637) network: add tcp listener backlog config (envoyproxy#12625) runtime: debug log that condition is always true when fractionalPercent numerator > denominator (envoyproxy#12068) WatchDog Extension hook (envoyproxy#12416) router: add dynamic metadata header formatter (envoyproxy#11858) statsd: revert visibility to public (envoyproxy#12621) Fix regression of /build_* in gitignore (envoyproxy#12630) Added a missing extension point to documentation. (envoyproxy#12620) Reverts proxy protocol test on windows (envoyproxy#12619) caching: Improved the tests and coverage of the CacheFilter tree (envoyproxy#12544) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new header formatter acts in the opposite direction
of the header-to-metadata filter. That is, it allows setting
a header from what's available in a request's metadata.
We need this to populate some request headers based on what
was previously extracted and transformed via the header-to-metadata
filter.
Risk Level: low
Testing: unit test
Docs Changes: yes
Release Notes: added
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com