caching: Improved the tests and coverage of the CacheFilter tree #12544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…ed it to common.h Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…cache misses, and delayed hits with a body - Also added more strict expectations for decoder callbacks to all tests Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…l immediate/delayed validation Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…tils_test Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…lidation conditional headers Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…to be cached as they require being revalidated anyway Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…d responses that may or may not require validation Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…test to debug it Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
yosrym93
changed the title
…ils_test Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
…heck for log string in stead of equality, as windows adds carriage returns to strings Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
|
@jmarantz is there anything that I need to do before this is ready for you to take a look? |
jmarantz
previously approved these changes
Aug 12, 2020
|
Needs a main merge. Thank you. /wait |
|
@mattklein123 done! |
|
@mattklein123 After merging master Which is weird because that test was not changed in the merge commit and it did not have any conflicts. Are there any recent changes to the integration tests framework that may cause this? |
|
It's a flake. We are working on fixing this. You can ignore for now! |
Alright then, the checks are done. This is the only failure. |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 14, 2020
* master: (67 commits) logger: support log control in admin interface and command line option for Fancy Logger (envoyproxy#12369) test: fix http_timeout_integration_test flake (envoyproxy#12654) [fuzz]added an input check in writefilter fuzzer and added test cases (envoyproxy#12628) add 'explicit' restriction. (envoyproxy#12643) scoped_rds_integration_test migrate from api v2 to api v3. (envoyproxy#12633) fuzz: added fuzz test for listener filter tls_inspector (envoyproxy#12617) testing: fix multiple race conditions in simulated time tests (envoyproxy#12527) [tls] Move handshaking behavior into SslSocketInfo. (envoyproxy#12571) header: getting rid of exception-throwing behaviors in header files [the rest] (envoyproxy#12611) router: add new ratelimited retry backoff strategy (envoyproxy#12202) [redis_proxy] added a constraint for route.prefix().size() (envoyproxy#12637) network: add tcp listener backlog config (envoyproxy#12625) runtime: debug log that condition is always true when fractionalPercent numerator > denominator (envoyproxy#12068) WatchDog Extension hook (envoyproxy#12416) router: add dynamic metadata header formatter (envoyproxy#11858) statsd: revert visibility to public (envoyproxy#12621) Fix regression of /build_* in gitignore (envoyproxy#12630) Added a missing extension point to documentation. (envoyproxy#12620) Reverts proxy protocol test on windows (envoyproxy#12619) caching: Improved the tests and coverage of the CacheFilter tree (envoyproxy#12544) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Improved the tests and coverage of the CacheFilter tree.
Signed-off-by: Yosry Ahmed yosryahmed@google.com
Additional Description:
fails_on_windowstag.Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Fixes #9872 as a side effect.