-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Add TLS sandbox #13844
examples: Add TLS sandbox #13844
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
latest docs render: https://storage.googleapis.com/envoy-pr/d687992/docs/start/sandboxes/tls.html |
@mattklein123 i created a separate pr to handle SNI here #13975 (its early wip) this one should be ready for final review hopefully - latest render is here https://storage.googleapis.com/envoy-pr/2f6d39c/docs/start/sandboxes/tls.html worth noting, ive added a "requirements" pullout its my ~intention to remove all of the "install docker" and "clone envoy repo" sections from the sandboxes and instead link a single page with these instructions - probably from this requirements box |
/retest |
Retrying Azure Pipelines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to ship and iterate! Very nice!
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: examples: Add TLS sandbox
Additional Description:
this provides the following examples
http
->https
https
->http
https
->https
https
passthroughRisk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #13373
[Optional Deprecated:]