Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add quick-start admin page #13847

Merged
merged 19 commits into from
Nov 10, 2020

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 31, 2020

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs: Add quick-start admin page
Additional Description:

  • separate out admin config info from other quick-start pages
  • add information about admin endpoints

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

phlax added 2 commits October 31, 2020 13:29
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
.azure-pipelines/pipelines.yml Outdated Show resolved Hide resolved
@phlax phlax marked this pull request as draft October 31, 2020 14:31
@mattklein123 mattklein123 self-assigned this Oct 31, 2020
@phlax
Copy link
Member Author

phlax commented Nov 1, 2020

i would also like to add a TLS page in quick-start, with info about Up/DownstreamContexts, a quick conceptual overview and pointers to examples (pending #13844)

once we have that page i think im happy with the quick-start guide for now in terms of pages/structure

phlax added 9 commits November 2, 2020 11:12
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added 2 commits November 6, 2020 10:05
This reverts commit 79f95b5.

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added 3 commits November 6, 2020 11:30
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] docs: Add quick-start admin page docs: Add quick-start admin page Nov 6, 2020
@phlax phlax marked this pull request as ready for review November 6, 2020 13:26
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Nov 6, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #13847 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Nov 9, 2020

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is awesome. Just a small comment and we can ship and iterate.

/wait

docs/root/start/quick-start/admin.rst Outdated Show resolved Hide resolved
Signed-off-by: Ryan Northey <ryan@synca.io>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 0ffcb6b into envoyproxy:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants