-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes usage of deprecated http2_protocol_options from Cluster in configs #15563
Removes usage of deprecated http2_protocol_options from Cluster in configs #15563
Conversation
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@phlax @alyssawilk @mattklein123 all of you are involved in the issue discussion so you might want to also do the review. Important: this does not fix the underlying issue, the tests should have been failing when we use a deprecated property. I don't fix it in this PR because I want to unblock #15461 which I want to get for 1.18 since it is important for Windows. Fixing the underlying issue is a test only change so we could fix it after the release. |
Signed-off-by: davinci26 <sotirisnan@gmail.com>
hi @davinci26 this pr raises a few issues firstly the example configs. I did a quick check and i think in most case we can just use im guessing some time in the future the other issue is not addressed in (or caused by) this PR - but it does raise the issue. replacing
doesnt seem very user-friendly to me. Especially as with this config the user is not actually setting any http2 options - they are switching http protocol. Despite the word |
the other issue is docs - reading the http2_protocol_option here: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/cluster.proto.html its not clear/obvous that this has been deprecated, or how to upgrade |
I see what you are saying. No strong opinion here. I just wanted my change to not affect the behavior. Also from a quick search in the repository, I see that there are many configs that already use the new verbose way of setting it.
I can see your argument but I am not well versed here to have an opinion. Would an issue be better to discuss this?
The link in there is broken, that makes it really confusing. We should patch this (I can do this in a separate PR) |
in terms of reverting to http1, i think im mostly concerned about the configs in the examples/sandboxes - just because they should be kept as simple as possible
yep. i think we also need a really standout way of flagging deprecation and perhaps new/old ways of doing things - beyond the scope of this PR tho, so sorry for hijacking it 8/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this to unblock @davinci26. I agree with @phlax that we can improve the documentation and simplify things, and I also agree that this new config is not very user friendly, but so it goes.
In terms of fixing the underlying reason it wasn't caught previously, we should have a way of not allowing parsing as v2 at all, but I'm not sure it's worth investing in that as we are about to delete v2 anyway.
So, let's merge and figure out doc improvements separately.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
Removes usage of deprecated http2_protocol_options from Cluster in configs. See #15559
Additional Description:
This patches the underlying issue that these configs should have caused tests to fail. This PR does not address this.
Required for #15461
Risk Level: Low (test only)
Testing: Tests
Docs Changes: N/A
Release Notes: N/A