examples: Remove http2 options/protocol from config where not required #15577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <ryan@synca.io>
|
follow on from #15563 initially i have just removed all and will readd the http2 options to any that fail ci |
|
the |
davinci26
previously approved these changes
Mar 19, 2021
phlax
changed the title
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
phlax
commented
Mar 20, 2021
| :lines: 7-15 | ||
| :lineno-start: 7 | ||
| :lines: 6-14 | ||
| :lineno-start: 6 |
There was a problem hiding this comment.
@mattklein123 just to highlight this - if configs in the examples dir are changed we need to check that they arent included in docs with line highlights etc
there arent many of them - they can be found by grepping for literalinclude and .yaml
yep
i wondered about this - either a sandbox - or something in getting started ive added a ticket regarding this #15605
yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: examples: Remove http2 options/protocol from config where not required
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]