http3: further cleanup and extension removal

api/envoy/extensions/transport_sockets/quic/v3/quic_transport.proto

@@ -14,7 +14,6 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
 
 // [#protodoc-title: quic transport]
 // [#comment:#extension: envoy.transport_sockets.quic]
-// [#comment:TODO(#12829): Remove this as an extension point.]
 
 // Configuration for Downstream QUIC transport socket. This provides Google's implementation of Google QUIC and IETF QUIC to Envoy.
 message QuicDownstreamTransport {

bazel/BUILD

@@ -299,6 +299,14 @@ config_setting(
     },
 )
 
+selects.config_setting_group(
+    name = "disable_http3_all_reasons",
+    match_any = [
+        ":disable_http3",
+        ":boringssl_fips",
+    ],
+)
+
 config_setting(
     name = "disable_hot_restart",
     values = {"define": "hot_restart=disabled"},

bazel/envoy_select.bzl

@@ -28,7 +28,7 @@ def envoy_select_google_grpc(xs, repository = ""):
 # Selects the given values if http3 is enabled in the current build.
 def envoy_select_enable_http3(xs, repository = ""):
     return select({
-        repository + "//bazel:disable_http3": [],
+        repository + "//bazel:disable_http3_all_reasons": [],
         "//conditions:default": xs,
     })
 

source/common/http/BUILD

@@ -2,6 +2,7 @@ load(
     "//bazel:envoy_build_system.bzl",
     "envoy_cc_library",
     "envoy_package",
+    "envoy_select_enable_http3",
 )
 
 licenses(["notice"])  # Apache 2
@@ -65,10 +66,10 @@ envoy_cc_library(
         "//source/common/config:utility_lib",
         "//source/common/http/http1:codec_lib",
         "//source/common/http/http2:codec_lib",
-        "//source/common/http/http3:quic_codec_factory_lib",
-        "//source/common/http/http3:well_known_names",
         "//source/common/network:filter_lib",
-    ],
+    ] + envoy_select_enable_http3([
+        "//source/common/quic:codec_lib",
+    ]),
 )
 
 envoy_cc_library(
@@ -259,8 +260,6 @@ envoy_cc_library(
         "//source/common/config:utility_lib",
         "//source/common/http/http1:codec_lib",
         "//source/common/http/http2:codec_lib",
-        "//source/common/http/http3:quic_codec_factory_lib",
-        "//source/common/http/http3:well_known_names",
         "//source/common/http/match_wrapper:config",
         "//source/common/network:utility_lib",
         "//source/common/router:config_lib",

source/common/http/codec_client.cc

@@ -10,11 +10,13 @@
 #include "common/http/exception.h"
 #include "common/http/http1/codec_impl.h"
 #include "common/http/http2/codec_impl.h"
-#include "common/http/http3/quic_codec_factory.h"
-#include "common/http/http3/well_known_names.h"
 #include "common/http/status.h"
 #include "common/http/utility.h"
 
+#ifdef ENVOY_ENABLE_QUIC
+#include "common/quic/codec_impl.h"
+#endif
+
 namespace Envoy {
 namespace Http {
 
@@ -182,11 +184,14 @@ CodecClientProd::CodecClientProd(Type type, Network::ClientConnectionPtr&& conne
     break;
   }
   case Type::HTTP3: {
-    codec_ = std::unique_ptr<ClientConnection>(
-        Config::Utility::getAndCheckFactoryByName<Http::QuicHttpClientConnectionFactory>(
-            Http::QuicCodecNames::get().Quiche)
-            .createQuicClientConnection(*connection_, *this));
+#ifdef ENVOY_ENABLE_QUIC
+    codec_ = std::make_unique<Quic::QuicHttpClientConnectionImpl>(
+        dynamic_cast<Quic::EnvoyQuicClientSession&>(*connection_), *this);
     break;
+#else
+    // Should be blocked by configuration checking at an earlier point.
+    NOT_REACHED_GCOVR_EXCL_LINE;
+#endif
   }
   }
 }

source/common/http/http3/BUILD

@@ -18,32 +18,11 @@ envoy_cc_library(
         "//include/envoy/upstream:upstream_interface",
         "//source/common/http:codec_client_lib",
         "//source/common/http:conn_pool_base_lib",
-    ],
-)
-
-envoy_cc_library(
-    name = "quic_codec_factory_lib",
-    hdrs = ["quic_codec_factory.h"],
-    deps = [
-        "//include/envoy/config:typed_config_interface",
-        "//include/envoy/http:codec_interface",
-        "//include/envoy/network:connection_interface",
+        "//source/common/quic:client_connection_factory_lib",
     ],
 )
 
 envoy_cc_library(
     name = "quic_client_connection_factory_lib",
     hdrs = ["quic_client_connection_factory.h"],
-    deps = [
-        "//include/envoy/config:typed_config_interface",
-        "//include/envoy/network:connection_interface",
-        "//include/envoy/ssl:context_config_interface",
-        "@envoy_api//envoy/config/core/v3:pkg_cc_proto",
-    ],
-)
-
-envoy_cc_library(
-    name = "well_known_names",
-    hdrs = ["well_known_names.h"],
-    deps = ["//source/common/singleton:const_singleton"],
 )

source/common/http/http3/conn_pool.cc

@@ -7,12 +7,17 @@
 
 #include "common/config/utility.h"
 #include "common/http/http3/quic_client_connection_factory.h"
-#include "common/http/http3/well_known_names.h"
 #include "common/http/utility.h"
 #include "common/network/address_impl.h"
 #include "common/network/utility.h"
 #include "common/runtime/runtime_features.h"
 
+#ifdef ENVOY_ENABLE_QUIC
+#include "common/quic/client_connection_factory_impl.h"
+#else
+#error "http3 conn pool should not be built with QUIC disabled"
+#endif
+
 namespace Envoy {
 namespace Http {
 namespace Http3 {
@@ -36,11 +41,9 @@ class Http3ConnPoolImpl : public FixedHttpConnPoolImpl {
       source_address = Network::Utility::getLocalAddress(host_address->ip()->version());
     }
     Network::TransportSocketFactory& transport_socket_factory = host->transportSocketFactory();
-    quic_info_ =
-        Config::Utility::getAndCheckFactoryByName<Http::QuicClientConnectionFactory>(
-            Http::QuicCodecNames::get().Quiche)
-            .createNetworkConnectionInfo(dispatcher, transport_socket_factory,
-                                         host->cluster().statsScope(), time_source, source_address);
+    quic_info_ = std::make_unique<Quic::PersistentQuicInfoImpl>(
+        dispatcher, transport_socket_factory, host->cluster().statsScope(), time_source,
+        source_address);
   }
 
   // Make sure all connections are torn down before quic_info_ is deleted.
@@ -68,11 +71,8 @@ allocateConnPool(Event::Dispatcher& dispatcher, Random::RandomGenerator& random_
         if (!source_address.get()) {
           source_address = Network::Utility::getLocalAddress(host_address->ip()->version());
         }
-        data.connection_ =
-            Config::Utility::getAndCheckFactoryByName<Http::QuicClientConnectionFactory>(
-                Http::QuicCodecNames::get().Quiche)
-                .createQuicNetworkConnection(*h3_pool->quic_info_, pool->dispatcher(), host_address,
-                                             source_address);
+        data.connection_ = Quic::createQuicNetworkConnection(
+            *h3_pool->quic_info_, pool->dispatcher(), host_address, source_address);
         return std::make_unique<ActiveClient>(*pool, data);
       },
       [](Upstream::Host::CreateConnectionData& data, HttpConnPoolImplBase* pool) {

source/common/http/http3/quic_client_connection_factory.h

@@ -1,12 +1,5 @@
 #pragma once
 
-#include <string>
-
-#include "envoy/config/core/v3/protocol.pb.h"
-#include "envoy/config/typed_config.h"
-#include "envoy/network/connection.h"
-#include "envoy/ssl/context_config.h"
-
 namespace Envoy {
 namespace Http {
 
@@ -16,28 +9,5 @@ struct PersistentQuicInfo {
   virtual ~PersistentQuicInfo() = default;
 };
 
-// A factory to create EnvoyQuicClientSession and EnvoyQuicClientConnection for QUIC
-class QuicClientConnectionFactory : public Config::UntypedFactory {
-public:
-  ~QuicClientConnectionFactory() override = default;
-
-  // Allows thread-local creation of PersistentQuicInfo.
-  // Each (thread local) connection pool can call createNetworkConnectionInfo to create a
-  // PersistentQuicInfo, then use that PersistentQuicInfo. when calling createQuicNetworkConnection
-  // for all the connections in that pool.
-  virtual std::unique_ptr<PersistentQuicInfo>
-  createNetworkConnectionInfo(Event::Dispatcher& dispatcher,
-                              Network::TransportSocketFactory& transport_socket_factory,
-                              Stats::Scope& stats_scope, TimeSource& time_source,
-                              Network::Address::InstanceConstSharedPtr server_addr) PURE;
-
-  virtual std::unique_ptr<Network::ClientConnection>
-  createQuicNetworkConnection(PersistentQuicInfo& info, Event::Dispatcher& dispatcher,
-                              Network::Address::InstanceConstSharedPtr server_addr,
-                              Network::Address::InstanceConstSharedPtr local_addr) PURE;
-
-  std::string category() const override { return "envoy.quic_connection"; }
-};
-
 } // namespace Http
 } // namespace Envoy

source/common/quic/BUILD

@@ -152,8 +152,6 @@ envoy_cc_library(
         "//include/envoy/http:codec_interface",
         "//include/envoy/registry",
         "//source/common/http/http3:quic_client_connection_factory_lib",
-        "//source/common/http/http3:quic_codec_factory_lib",
-        "//source/common/http/http3:well_known_names",
         "//source/extensions/transport_sockets/tls:ssl_socket_lib",
         "@com_googlesource_quiche//:quic_core_http_spdy_session_lib",
     ],
@@ -170,8 +168,6 @@ envoy_cc_library(
         ":envoy_quic_utils_lib",
         "//include/envoy/http:codec_interface",
         "//include/envoy/registry",
-        "//source/common/http/http3:quic_codec_factory_lib",
-        "//source/common/http/http3:well_known_names",
         "@com_googlesource_quiche//:quic_core_http_spdy_session_lib",
     ],
 )

source/common/quic/client_connection_factory_impl.cc

@@ -24,11 +24,21 @@ PersistentQuicInfoImpl::PersistentQuicInfoImpl(
           std::make_unique<quic::QuicCryptoClientConfig>(std::make_unique<EnvoyQuicProofVerifier>(
               stats_scope, getConfig(transport_socket_factory), time_source))) {}
 
+namespace {
+// TODO(mattklein123): This is mutable static info that is required for the QUICHE code. This was
+// preexisting but should be removed as we shouldn't be using global mutable static data.
+struct StaticInfo {
+  quic::QuicConfig quic_config_;
+  quic::QuicClientPushPromiseIndex push_promise_index_;
+
+  static StaticInfo& get() { MUTABLE_CONSTRUCT_ON_FIRST_USE(StaticInfo); }
+};
+} // namespace
+
 std::unique_ptr<Network::ClientConnection>
-QuicClientConnectionFactoryImpl::createQuicNetworkConnection(
-    Http::PersistentQuicInfo& info, Event::Dispatcher& dispatcher,
-    Network::Address::InstanceConstSharedPtr server_addr,
-    Network::Address::InstanceConstSharedPtr local_addr) {
+createQuicNetworkConnection(Http::PersistentQuicInfo& info, Event::Dispatcher& dispatcher,
+                            Network::Address::InstanceConstSharedPtr server_addr,
+                            Network::Address::InstanceConstSharedPtr local_addr) {
   // This flag fix a QUICHE issue which may crash Envoy during connection close.
   SetQuicReloadableFlag(quic_single_ack_in_packet2, true);
   PersistentQuicInfoImpl* info_impl = reinterpret_cast<PersistentQuicInfoImpl*>(&info);
@@ -37,14 +47,14 @@ QuicClientConnectionFactoryImpl::createQuicNetworkConnection(
       quic::QuicUtils::CreateRandomConnectionId(), server_addr, info_impl->conn_helper_,
       info_impl->alarm_factory_, quic::ParsedQuicVersionVector{info_impl->supported_versions_[0]},
       local_addr, dispatcher, nullptr);
+  auto& static_info = StaticInfo::get();
   auto ret = std::make_unique<EnvoyQuicClientSession>(
-      quic_config_, info_impl->supported_versions_, std::move(connection), info_impl->server_id_,
-      info_impl->crypto_config_.get(), &push_promise_index_, dispatcher, 0);
+      static_info.quic_config_, info_impl->supported_versions_, std::move(connection),
+      info_impl->server_id_, info_impl->crypto_config_.get(), &static_info.push_promise_index_,
+      dispatcher, 0);
   ret->Initialize();
   return ret;
 }
 
-REGISTER_FACTORY(QuicClientConnectionFactoryImpl, Http::QuicClientConnectionFactory);
-
 } // namespace Quic
 } // namespace Envoy